Re: [PATCH 3/4] PM/Hibernate: Use memory allocations to free memory (rev. 2)

Rafael J. Wysocki
2009-05-03T16:35:06Z

On Sunday 03 May 2009, Pavel Machek wrote:
> Hi!

Hi,

> > > Remove the shrinking of memory from the suspend-to-RAM code, where it is
> > > not really necessary.
> >
> > Hmm. Shouldn't we do this _regardless_?
> >
> > IOW, shouldn't this be a totally separate patch? It seems to be left-over
> > from when we shared the same code-paths, and before the split of the STR
> > and hibernate code?
> >
> > IOW, shouldn't the very _first_ patch just be this part? That code doesn't
> > make any sense anyway (that FREE_PAGE_NUMBER really _is_ totally
> > arbitrary).
> >
> > This part seems to be totally independent of all the other parts in your
> > patch-series. No?
>
> I'm not sure this one is a good idea: drivers will need to allocate
> memory during suspend/resume, and when processes are frozen/disk
> driver is suspended, normal memory management will no longer work.
>
> So, freeing 4M of memory before starting suspend seems like a good
> idea. That way those small alocations will not fail.

I don't think we've ever had problems with the drivers having too little
memory to suspend.

I'm opting for removing this code and seeing if that leads to any regressions.
If it does, we can still get some free memory by allocating and releasing it.

Thanks,
Rafael