Re: [PATCH 0/4] PM: Drop shrink_all_memory (rev. 2) (was: Re: [PATCH 3/3] PM/Hibernate: Use memory allocations to free memory)

Pavel Machek
2009-05-04T20:27:11Z

On Mon 2009-05-04 21:53:36, Rafael J. Wysocki wrote:
> On Monday 04 May 2009, Pavel Machek wrote:
> > Hi!
> >
> > > I know that swsusp_shrink_memory() has problems, that's why I'd like to get rid
> > > of it.
> > >
> > > > I wonder if it's possible to free up the memory within 1s at all.
> > >
> > > I'm not sure.
> > >
> > > Apparently, the counting of saveable pages takes substantial time (0.5 s each
> > > iteration on my 64-bit test box), so we can improve that by limiting the number
> > > of iterations.
> >
> > We could increase step size after each step. Free in 40MB step, then
> > 80MB step, then 160MB step, ...
>
> Why not just one step? It doesn't seem to hurt performance AFAICS.

One step is obviously fine, too.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html