Re: [Bug #12422] 2.6.28-git can't resume from str

Ingo Molnar
2009-01-13T01:28:00Z

* Jeff Chua <jeff.chua.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> On Mon, Jan 12, 2009 at 2:07 AM, Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org> wrote:
> >> Everything in-between should have
> >> a0e280e0f33f6c859a235fb69a875ed8f3420388 applied?
> > not necessarily - if an intermediate tree that is checked happened to have
> > been based on some earlier -rc, it might have that bug included. Safest is
> > to always cherry-pick that commit. (if it has no dependencies)
>
> Thanks for pointing this out. My bisect was thrown off course because
> I didn't "cherry-pick" that commit.
>
> After cherry picking, I ended up with the same commit as was reported by
> Christian Borntraeger -- "Regression 2.6.28-git: suspend/resume
> failure. git bisected to usb suspend/resume patch".
>
> I was trying to bisect further, but ended up with this strange behavior...
>
> # start with a "fresh linux git download".
> # ls
> . .. .git .gitignore .mailmap COPYING
> CREDITS Documentation Kbuild MAINTAINERS Makefile README
> REPORTING-BUGS arch block crypto drivers firmware
> fs include init ipc kernel lib
> mm net samples scripts security sound
> usr virt
>
> # git bisect bad ae04d1401577bb63151480a053057de58b8e10bb
> # git bisect good a3a798c88a14b35e5d4ca30716dbc9eb9a1ddfe2
> Bisecting: 579 revisions left to test after this
> [079899c2384023cd8efcd3806680b4f1d2abbd54] Btrfs: Change
> find_extent_buffer to use TestSetPageLocked
>
> # ls
> . .. .git fs
>
> Is this a bug or a feature?

that's a feature - the btrfs history looks like this. You can mark get out
of that bisection set by doing this:

git bisect good 34353029534a08e41cfb8be647d734b9ce9ebff8

Ingo