Re: [Bug #14791] Something has been broken in the network stack this week

Ben Hutchings
2010-01-10T22:46:56Z

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

On Sun, 2010-01-10 at 23:27 +0100, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.32. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14791
> Subject : Something has been broken in the network stack this week
> Submitter : Delete This Account <speedyboyinovator@hotmail.com>
> Date : 2009-12-12 13:06 (30 days old)

You can mark this as Handled-by me, but I'm waiting for someone
(anyone!) to verify that this can be solved by reverting changes to this
driver made by commit 37e8273cd30592d3a82bcb70cbb1bdc4eaeb6b71. The
submitter has disappeared.

The patch is trivial:

--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -419,7 +419,7 @@

static const struct driver_info cdc_info = {
.description = "CDC Ethernet Device",
- .flags = FLAG_ETHER | FLAG_LINK_INTR,
+ .flags = FLAG_ETHER,
// .check_connect = cdc_check_connect,
.bind = cdc_bind,
.unbind = usbnet_cdc_unbind,
--- END ---

Ben.

--
Ben Hutchings
The generation of random numbers is too important to be left to chance.
- Robert Coveyou

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]