Re: [Bug #14730] sky2 won't work after suspend/resume cycle

OGAWA Hirofumi
2009-12-29T18:41:30Z

"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org> writes:

> This message has been generated automatically as a part of a report
> of regressions introduced between 2.6.31 and 2.6.32.
>
> The following bug entry is on the current list of known regressions
> introduced between 2.6.31 and 2.6.32. Please verify if it still should
> be listed and let me know (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14730
> Subject : sky2 won't work after suspend/resume cycle
> Submitter : Maciej J. Woloszyk <mat-7wKBDC4inUHVItvQsEIGlw@public.gmane.org>
> Date : 2009-12-04 09:02 (26 days old)

This seems to be related to commit 4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff.

It clears dev->state_saved blindly, but pci_pm_resume() calls
pci_restore_standard_config() before pm->resume() (by probably
historical reason).

So, I guess it became the cause of restore regression before changing
PCI power state. It might be better to revert
4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff for now, until changing pci
generic stuff.

Thanks.
--
OGAWA Hirofumi <hirofumi-UIVanBePwB70ZhReMnHkpc8NsWr+9BEh@public.gmane.org>