Re: [Bug #14894] pohmelfs: NULL pointer dereference

Greg KH
2010-02-02T21:18:09Z

On Tue, Feb 02, 2010 at 11:57:43PM +0300, Evgeniy Polyakov wrote:
> Hi.
>
> Sorry, it took really long to catch all the things around, but it is
> better than never.
>
> History says that commit which introduced per-bdi writeback broke
> pohmelfs, since it does not have backing store device and did not fill
> appropriate superblock entry, which lead to crash on umoount.
>
> Jens provided a patch below, which I tested to fix the problem.
> There is a problem though, when all writes happend before umount,
> but did net yet written back to storage, get lost. I can not say whether
> this happens because of per-bdi writeback (it should not I think), but
> that's what happens.
>
> Albeit being a bug, it will not be fixed :)
> The reason is simple, new backing storage for POHMELFS (a distributed
> hash table called elliptics network) is essentially ready and I start
> working on porting POHMELFS to it, which means all its bugs will be
> fixed there^W^Werased and written from scratch.
>
> Jens, thanks a lot for you patch, Greg please pull it up.
> If you did not find it or can not extract from the reply, I will resend.

Please resend it with a signed-off-by line so that I can apply it.

thanks,

greg k-h