Re: [Bug #13941] x86 Geode issue

Ingo Molnar
2009-08-16T21:01:34Z

* Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org> wrote:

>
> * Martin-Éric Racine <q-funk-X3B1VOXEql0@public.gmane.org> wrote:
>
> > On Thu, Aug 13, 2009 at 9:34 PM, Rafael J. Wysocki<rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> > > On Thursday 13 August 2009, Martin-Éric Racine wrote:
> > >> On Thu, Aug 13, 2009 at 5:54 PM, Rafael J. Wysocki<rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> > >> > On Thursday 13 August 2009, Martin-Éric Racine wrote:
> > >> >> 2009/8/13 Martin-Éric Racine <q-funk-X3B1VOXEql0@public.gmane.org>:
> > >> >> > On Thu, Aug 13, 2009 at 12:07 PM, Ingo Molnar<mingo-X9Un+BFzKDI@public.gmane.org> wrote:
> > >> >> >> * Martin-Éric Racine <q-funk-X3B1VOXEql0@public.gmane.org> wrote:
> > >> >> >>> Yes, this bug is still valid.
> > >> >> >>>
> > >> >> >>> Ubuntu kernel team member Leann Ogasawara and I are slowly
> > >> >> >>> bisecting our way through the changes that took place since 2.6.30
> > >> >> >>> to find the commit that introduced this regression. Please stay
> > >> >> >>> tuned.
> > >> >> >>
> > >> >> >> hm, the only outright Geode related commit was:
> > >> >> >>
> > >> >> >>  d6c585a: x86: geode: Mark mfgpt irq IRQF_TIMER to prevent resume failure
> > >> >> >>
> > >> >> >> the jpg at:
> > >> >> >>
> > >> >> >>  http://launchpadlibrarian.net/28892781/00002.jpg
> > >> >> >>
> > >> >> >> is very out of focus - but what i could decypher suggests a
> > >> >> >> pagefault crash in the VFS code, in generic_delete_inode().
> > >> >>
> > >> >> This one might be a bit better:
> > >> >>
> > >> >> http://launchpadlibrarian.net/30267494/2.6.31-5.24.jpg
> > >
> > > Hmm.  This looks like a sysfs oops to my untrained eye.
> >
> > The bisect I did with Leann Ogasawara has narrowed the kernel panic
> > down to the following:
> >
> > commit f19d4a8fa6f9b6ccf54df0971c97ffcaa390b7b0
> > Author: Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
> > Date: Mon Jun 8 19:50:45 2009 -0400
> >
> > add caching of ACLs in struct inode
> >
> > No helpers, no conversions yet.
> >
> > Signed-off-by: Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
>
> Weird. If the functions do what their name suggests, i.e. if
> inode_init_always() is an always called constructor and if
> destroy_inode() is an unconditional destructor then this patch
> should have no functional effect on the VFS side.
>
> It increases the size of struct inode, so if you have some old
> module (built to an older version of fs.h) still around it might
> corrupt your inode data structure.
>
> Or the size change might trigger some dormant bug. It might move a
> critical inode right into the path of a pre-existing (but not
> visibly crash-triggering) data corruption.
>
> The possibilities on the 'weird bug' front are endless - the
> crash/oops itself should be turned into text, posted here and
> analyzed.

Btw., before you invest any time into the 'weird crash' theory, i'd
suggest to double check the bisection result:

f19d4a8fa6f9b6ccf54df0971c97ffcaa390b7b0 crashes
f19d4a8fa6f9b6ccf54df0971c97ffcaa390b7b0~1 boots fine

You can save yourself from a lot of head scratching that way - the
bisection result looks weird. (albeit plausible - a VFS crash points
to a VFS commit.)

_Maybe_ the bisection is just off a little bit (there was a
bisection mistake in the last few steps), and the real buggy commit
is one of the nearby ones:

1cbd20d: switch xfs to generic acl caching helpers
073aaa1: helpers for acl caching + switch to those
06b16e9: switch shmem to inode->i_acl
281eede: switch reiserfs to inode->i_acl
7a77b15: switch reiserfs to usual conventions for caching ACLs
e68888b: reiserfs: minimal fix for ACL caching
d441b1c: switch nilfs2 to inode->i_acl
5affd88: switch btrfs to inode->i_acl
290c263: switch jffs2 to inode->i_acl
05fc079: switch jfs to inode->i_acl
d4bfe2f: switch ext4 to inode->i_acl
6582a0e: switch ext3 to inode->i_acl
5e78b43: switch ext2 to inode->i_acl
f19d4a8: add caching of ACLs in struct inode
3e63cbb: fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls
01c0319: cleanup __writeback_single_inode
f21f622: ... and the same for vfsmount id/mount group id
c63e09e: Make allocation of anon devices cheaper
7e325d3: update Documentation/filesystems/Locking
f6cc746: devpts: remove module-related code
3b22edc: VFS: Switch init_mount_tree() to use the new create_mnt_ns() helper
654f562: vfs: fix nd->root leak in do_filp_open()
b5450d9: reiserfs: remove stray unlock_super in reiserfs_resize
c912e7a: ALSA: hda - Fix support for Samsung P50 with AD1986A codec

Ingo