Re: [Bug #14474] restorecond going crazy on 2.6.31.4 - inotify regression?

Rafael J. Wysocki
2009-10-27T20:27:40Z

On Tuesday 27 October 2009, Eric Paris wrote:
> On Tue, Oct 27, 2009 at 4:24 AM, Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> > On Tuesday 27 October 2009, Robert Hancock wrote:
> >> On Mon, Oct 26, 2009 at 1:32 PM, Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> >> > This message has been generated automatically as a part of a report
> >> > of regressions introduced between 2.6.30 and 2.6.31.
> >> >
> >> > The following bug entry is on the current list of known regressions
> >> > introduced between 2.6.30 and 2.6.31. Please verify if it still should
> >> > be listed and let me know (either way).
> >> >
> >> >
> >> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=14474
> >> > Subject : restorecond going crazy on 2.6.31.4 - inotify regression?
> >> > Submitter : Robert Hancock <hancockrwd-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> > Date : 2009-10-16 0:03 (11 days old)
> >> > References : http://marc.info/?l=linux-kernel&m=125565159520489&w=4
> >>
> >> This is definitely reproducible on 2.6.31.4 on CentOS 5.4, I'll likely
> >> try 2.6.31.5 shortly, but it doesn't seem like any of the 2.6.31.5
> >> patches touch inotify..
>
> It's a restorecond bug. restorecon acted as if watch descriptors
> could never be reused. They weren't on old kernels and it's possible
> they are reused now. Restorecon was fixed.
>
> http://marc.info/?l=selinux&m=125380417916233&w=2
>
> a change in the kernel caused a buggy userspace program to break. I
> know how to put the kernel back the way it was, but I don't know if we
> call this a regression, you guys tell me.

Yes, we do, AFAICS. The policy is not to break user space, even if it happens
to work by accident.

Thanks,
Rafael