Re: [PATCH 03/18] nvme: add TCP TSAS definitions

Sagi Grimberg
2023-03-21T13:46:33Z

On 3/21/23 14:43, Hannes Reinecke wrote:
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> include/linux/nvme.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 779507ac750b..ea961ca2022d 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -108,6 +108,13 @@ enum {
> NVMF_RDMA_CMS_RDMA_CM = 1, /* Sockets based endpoint addressing */
> };
>
> +/* TSAS SECTYPE for TCP transport */
> +enum {
> + NVMF_TCP_SECTYPE_NONE = 0, /* No Security */
> + NVMF_TCP_SECTYPE_TLS12 = 1, /* TLSv1.2, NVMe-oF 1.1 and NVMe-TCP 3.6.1.1 */
> + NVMF_TCP_SECTYPE_TLS13 = 2, /* TLSv1.3, NVMe-oF 1.1 and NVMe-TCP 3.6.1.1 */
> +};

I think these should be located in nvme-tcp.h
Otherwise looks good,

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

> +
> #define NVME_AQ_DEPTH 32
> #define NVME_NR_AEN_COMMANDS 1
> #define NVME_AQ_BLK_MQ_DEPTH (NVME_AQ_DEPTH - NVME_NR_AEN_COMMANDS)
> @@ -1458,6 +1465,9 @@ struct nvmf_disc_rsp_page_entry {
> __u16 pkey;
> __u8 resv10[246];
> } rdma;
> + struct tcp {
> + __u8 sectype;
> + } tcp;
> } tsas;
> };
>