Re: [PATCH 05/18] net/tls: implement ->read_sock()

Hannes Reinecke
2023-03-29T15:41:54Z

On 3/29/23 17:37, Sagi Grimberg wrote:
>
>> Implement ->read_sock() function for use with nvme-tcp.
>
> Nice.
>
>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>> Cc: Boris Pismenny <boris.pismenny@gmail.com>
>
> Would be great to see a tls_device implementation as well.

Sheesh. But first we would need to update the tls_device implementation
to TLS 1.3:

int tls_set_device_offload(struct sock *sk, struct tls_context *ctx)
[ .. ]
crypto_info = &ctx->crypto_send.info;
if (crypto_info->version != TLS_1_2_VERSION) {
rc = -EOPNOTSUPP;
goto release_netdev;
}

which I'd rather defer to Boris or whoever maintains the hardware.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman