Re: [PATCH 09/18] nvme-tcp: enable TLS handshake upcall

Hannes Reinecke
2023-03-30T12:59:53Z

On 3/30/23 14:54, Daniel Wagner wrote:
> On Wed, Mar 29, 2023 at 03:59:29PM +0200, Hannes Reinecke wrote:
> --- a/drivers/nvme/host/fabrics.c
>> +++ b/drivers/nvme/host/fabrics.c
>> @@ -609,6 +609,7 @@ static const match_table_t opt_tokens = {
>> { NVMF_OPT_DISCOVERY, "discovery" },
>> { NVMF_OPT_DHCHAP_SECRET, "dhchap_secret=%s" },
>> { NVMF_OPT_DHCHAP_CTRL_SECRET, "dhchap_ctrl_secret=%s" },
>> + { NVMF_OPT_TLS, "tls" },
>> { NVMF_OPT_ERR, NULL }
>> };
>
> This should be ifdef out for !CONFIG_NVME_TLS

No, I did that on purpose.
Error handling in the fabrics option parsing is notoriously bad, and if
we disable that nvme-cli will fail with annoying interfaces.
As it stands, the 'tls' option will be accepted, but you'll get a kernel
message telling you it's not compiled in, and the function returns -EINVAL.

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Frankenstr. 146, 90461 Nürnberg
Managing Directors: I. Totev, A. Myers, A. McDonald, M. B. Moerman
(HRB 36809, AG Nürnberg)