Re: [PATCH 18/18] nvmet-tcp: add configfs attribute 'param_keyring'

Hannes Reinecke
2023-04-14T10:31:01Z

On 4/3/23 17:53, Sagi Grimberg wrote:
>
>>>> Add a configfs attribute to list and change the default keyring.
>>>
>>> is the keyring an attribute of a port? or a subsystem? Why the choice
>>> of making it per port?
>>>
>> As per discussion at fmds each port might want to use different
>> credentials.
>> We can move it to subsystems if we decide we don't want to support
>> that use-case.
>
> I think we should move it to the subsystem in Linux.
>
Easier said than done.

We can only fetch the subsystem once we have the NQN, which we will
know after the connect command.
But out of necessity the connect command will only be transferred
after TLS handshake completed, so there is not subsystem NQN allowing
us to figure out the correct subsystem.

So we'll have to keep it at the port level, I'm afraid.

Cheers,

Hannes