Re: [PATCH 05/18] net/tls: implement ->read_sock()

Sagi Grimberg
2023-03-29T15:43:25Z

>>> Implement ->read_sock() function for use with nvme-tcp.
>>
>> Nice.
>>
>>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>>> Cc: Boris Pismenny <boris.pismenny@gmail.com>
>>
>> Would be great to see a tls_device implementation as well.
>
> Sheesh. But first we would need to update the tls_device implementation
> to TLS 1.3:

;)

The comment was for the nvidia folks..

> int tls_set_device_offload(struct sock *sk, struct tls_context *ctx)
> [ .. ]
>         crypto_info = &ctx->crypto_send.info;
>         if (crypto_info->version != TLS_1_2_VERSION) {
>                 rc = -EOPNOTSUPP;
>                 goto release_netdev;
>         }
>
> which I'd rather defer to Boris or whoever maintains the hardware