Re: [PATCH 08/18] nvme-tcp: do not set MSG_SENDPAGE_NOTLAST

Jakub Kicinski
2023-04-17T20:16:56Z

On Mon, 17 Apr 2023 18:28:12 +0300 Sagi Grimberg wrote:
> > But then we're running afoul with tls_sw_do_sendpage(), which uses
> > MSG_SENDPAGE_NOTLAST as a record indicator. Forwarding
> > MSG_SENDPAGE_NOTLAST to tls results in incorrect TLS records on the wire
> > and a transmission stall.
> >
> > Took me days to figure that out.
> >
> > If you have a better idea, I'm all ears.
>
> So sendfile is unsupported over kTLS? Or is there some special
> case for it in the upper layer?
>
> Jakub?

First I hear of it. 10 sec look at the code doesn't indicate that
the author missed this case completely either.

Hannes, any more details on what's going wrong?

What incorrect TLS record have you seen? What's the sequence of sends?
Offload or no offload? Easy to repro or stars need to (mis)align?