Re: [PATCH 08/18] nvme-tcp: do not set MSG_SENDPAGE_NOTLAST

Sagi Grimberg
2023-04-17T15:10:24Z

nak from me.

> MSG_SENDPAGE_NOTLAST was introduced with commit 35f9c09fe9c7
> ("tcp: tcp_sendpages() should call tcp_push() once") to fix issues
> with the ->sendfile() call, and the implication seems to be that
> the flag should be strictly internal to sendfile.

no, the use case was to allow sendpage consumers to build larger
tso packets for large payloads (splice being the primary one), nvme-tcp
also benefits from it (as do others), just like sendfile.

> Hence we shouldn't be setting it on nvme-tcp, and anyway doing
> so will cause TLS sending invalid data.

That is something else. I don't recall the full details on the
discussion with Jakub, but it was not my intention to strike
it altogether, just remove it if !sendpage_ok.