Re: [PATCH 2/2] nfs: create a kernel keyring

Christoph Hellwig
2025-06-02T15:25:29Z

On Sat, May 17, 2025 at 12:45:02PM +0300, Sagi Grimberg wrote:
>
>
> On 16/05/2025 20:03, Jarkko Sakkinen wrote:
>> On Fri, May 16, 2025 at 02:47:18PM +0300, Sagi Grimberg wrote:
>>> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>> Based on?
>
> Based on the same that nvme is doing. The only reason I see to have it
> is to avoid having the user explicitly set perms on the key for tlshd to be
> able to load it. nvme creates its own keyring that possessors can use, so
> makes
> sense that nfs has this keyring as well.

Jarkoo, can you please state your objections clearly? You've only
asked this one liner question in response to Sagi's question but not
even commented the original patch.