Re: [PATCH net-next 05/15] quic: provide quic.h header files for kernel and userspace

[David Howells <dhowells@redhat.com>]

Xin Long <lucien.xin@gmail.com> wrote:

> +#ifndef __uapi_quic_h__
> +#define __uapi_quic_h__

I think capital letters are preferred for system headers, e.g.:
_UAPI_LINUX_QUIC_H.

> +enum quic_crypto_level {
> +	QUIC_CRYPTO_APP,
> +	QUIC_CRYPTO_INITIAL,
> +	QUIC_CRYPTO_HANDSHAKE,
> +	QUIC_CRYPTO_EARLY,
> +	QUIC_CRYPTO_MAX,
> +};

I would recommend that you assign explicit values to enums in uapi headers to
avoid accidental changes if someone tries inserting in the middle of the list.

> +struct quic_transport_param {
> +	uint8_t		remote;
> +	uint8_t		disable_active_migration;
> +	uint8_t		grease_quic_bit;

I believe use of __u8, __u16, __s32 and similar is preferred to uint8_t,
uint16_t, int32_t, etc. in UAPI headers.

> +enum {
> +	QUIC_TRANSPORT_ERROR_NONE,
> +	QUIC_TRANSPORT_ERROR_INTERNAL,
> +	QUIC_TRANSPORT_ERROR_CONNECTION_REFUSED,

Again, recommend assigning actual values.

David