From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 10 Oct 2019 11:30:11 +0200 From: Cyril Hrubis Subject: Re: [RFC PATCH] LTP Wrapper for Syzkaller reproducers Message-ID: <20191010093011.GA2508@rei.lan> References: <20191009142446.6997-1-rpalethorpe@suse.com> <20191009145416.GA5014@rei.lan> <20191009180447.GD15291@rei.lan> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline List-ID: To: Dmitry Vyukov Cc: Richard Palethorpe , syzkaller , kernelci@groups.io, shuah , ltp@lists.linux.it, George Kennedy , Cyril Hrubis , "open list : KERNEL SELFTEST FRAMEWORK" , automated-testing@yoctoproject.org Hi! > > > > Indeed, it's removed recursively by the test library. > > > > > > :popcorn: > > > > > > It took me several years to figure out how to more or less reliably > > > remove dirs after the fuzzer ;) > > > (no, unlink won't do ;)) > > > > I guess that there are things such as immutable file attributes that has > > to be cleared and many more. Do you have piece of code somewhere that we > > can look into to spare us from reinventing the wheel? > > Here is what we have: > https://github.com/google/syzkaller/blob/c4b9981b5f5b70dc03eb3f76c618398510101a1d/executor/common_linux.h#L2358-L2461 > Maybe it can be simplified, but that's what we ended up with after > some organic evolution. At least the comments may give some hints as > to what may go wrong. Thanks a lot! Also I see that you are using namespaces, and much more, to sandbox the fuzzer, I was wondering if we should do that, at least separate user and pid namespace sounds like a good idea to me. -- Cyril Hrubis chrubis@suse.cz