From: Greg KH <gregkh@linuxfoundation.org>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
Michal Marek <michal.lkml@markovi.net>,
Masahiro Yamada <masahiroy@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
clang-built-linux <llvm@lists.linux.dev>,
Bill Wendling <morbo@google.com>,
Nathan Chancellor <nathan@kernel.org>,
regressions@lists.linux.dev,
"gustavo.padovan@collabora.com" <gustavo.padovan@collabora.com>,
Guillaume Charles Tucker <guillaume.tucker@collabora.com>,
denys.f@collabora.com, kernelci@lists.linux.dev
Subject: Re: [PATCH v4] Makefile.compiler: replace cc-ifversion with compiler-specific macros
Date: Mon, 22 May 2023 17:52:32 +0100 [thread overview]
Message-ID: <2023052247-bobtail-factsheet-d104@gregkh> (raw)
In-Reply-To: <87353ok78h.fsf@rcn-XPS-13-9305.i-did-not-set--mail-host-address--so-tickle-me>
On Mon, May 22, 2023 at 12:09:34PM +0200, Ricardo Cañuelo wrote:
> On vie, may 19 2023 at 08:57:24, Nick Desaulniers <ndesaulniers@google.com> wrote:
> > It could be; if the link order was changed, it's possible that this
> > target may be hitting something along the lines of:
> > https://isocpp.org/wiki/faq/ctors#static-init-order i.e. the "static
> > initialization order fiasco"
> >
> > I'm struggling to think of how this appears in C codebases, but I
> > swear years ago I had a discussion with GKH (maybe?) about this. I
> > think I was playing with converting Kbuild to use Ninja rather than
> > Make; the resulting kernel image wouldn't boot because I had modified
> > the order the object files were linked in. If you were to randomly
> > shuffle the object files in the kernel, I recall some hazard that may
> > prevent boot.
>
> I thought that was specifically a C++ problem? But then again, the
> kernel docs explicitly say that the ordering of obj-y goals in kbuild is
> significant in some instances [1]:
Yes, it matters, you can not change it. If you do, systems will break.
It is the only way we have of properly ordering our init calls within
the same "level".
thanks,
greg k-h
next prev parent reply other threads:[~2023-05-22 16:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAK7LNAT_cMLGLBz7ugaLpJD3QmZmY8FK56x9nihvWeYhJpi2ag@mail.gmail.com>
[not found] ` <20220919170828.3718437-1-ndesaulniers@google.com>
[not found] ` <597ef55f-e7c1-ab60-b4aa-0071ff4b5e0e@collabora.com>
[not found] ` <325ae81d-b3a5-71b3-39e9-96408968ab0b@leemhuis.info>
2023-05-02 9:48 ` [PATCH v4] Makefile.compiler: replace cc-ifversion with compiler-specific macros Shreeya Patel
2023-05-02 11:58 ` Linux regression tracking (Thorsten Leemhuis)
[not found] ` <CAKwvOdmSrAxx-YY1Na3BSdYuxXCPKK+F0K5V6i+adTn_bVJEsw@mail.gmail.com>
2023-05-03 21:02 ` Shreeya Patel
2023-05-03 21:15 ` Nick Desaulniers
2023-05-03 22:33 ` Shreeya Patel
2023-05-15 23:01 ` Nick Desaulniers
2023-05-17 8:34 ` Shreeya Patel
2023-05-17 15:39 ` Ricardo Cañuelo
2023-05-17 16:27 ` Nick Desaulniers
2023-05-18 14:23 ` Ricardo Cañuelo
2023-05-18 21:12 ` Nick Desaulniers
2023-05-19 8:35 ` Ricardo Cañuelo
2023-05-19 15:57 ` Nick Desaulniers
2023-05-22 10:09 ` Ricardo Cañuelo
2023-05-22 16:52 ` Greg KH [this message]
2023-05-22 19:52 ` Nick Desaulniers
2023-05-22 20:01 ` Greg KH
2023-05-22 20:16 ` Nick Desaulniers
2023-05-23 10:27 ` Shreeya Patel
2023-05-23 21:27 ` Nick Desaulniers
2023-06-12 10:10 ` Shreeya Patel
2023-06-20 4:19 ` Masahiro Yamada
2023-07-10 12:09 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-11 11:16 ` Shreeya Patel
2023-08-29 11:28 ` Linux regression tracking (Thorsten Leemhuis)
2023-09-11 10:05 ` Thorsten Leemhuis
2023-09-15 9:33 ` Shreeya Patel
2023-09-30 10:24 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023052247-bobtail-factsheet-d104@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=denys.f@collabora.com \
--cc=guillaume.tucker@collabora.com \
--cc=gustavo.padovan@collabora.com \
--cc=kernelci@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=regressions@lists.linux.dev \
--cc=ricardo.canuelo@collabora.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox