From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <62c11336-cac1-8501-19fe-980ebfa050e9@collabora.com> Date: Thu, 10 Mar 2022 22:21:57 +0500 MIME-Version: 1.0 Subject: Re: [PATCH 1/2] selftests/lkdtm: add config and turn off CFI_FORWARD_PROTO References: <20220217205620.2512094-1-usama.anjum@collabora.com> <202203091122.A51B31230A@keescook> From: "Usama" In-Reply-To: <202203091122.A51B31230A@keescook> Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-ID: To: Kees Cook Cc: usama.anjum@collabora.com, Shuah Khan , kernel@collabora.com, kernelci@groups.io, Greg Kroah-Hartman , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org On 3/10/22 12:22 AM, Kees Cook wrote: > On Fri, Feb 18, 2022 at 01:56:19AM +0500, Muhammad Usama Anjum wrote: >> Add config options which are needed for LKDTM sub-tests. >> STACKLEAK_ERASING test needs GCC_PLUGIN_STACKLEAK config. >> READ_AFTER_FREE and READ_BUDDY_AFTER_FREE tests need >> INIT_ON_FREE_DEFAULT_ON config. >> >> CFI_FORWARD_PROTO always fails as there is no active CFI system of some >> kind. Turn it off for now by default until proper support. > > Building under LTO Clang on arm64, this is available. What's the right > way to add a CONFIG that isn't always available? > > -Kees Yeah, as you had mentioned (https://github.com/kernelci/kernelci-project/issues/84#issuecomment-1042015431): CFI_FORWARD_PROTO is going to fail unless there is an active CFI system in place of some kind. Right now this depends on arm64+Clang. In the future, this will be arch-agnostic+Clang, but for the moment, it should be safe to exclude this test. In this patch, I'm turning off CFI_FORWARD_PROTO by default here. We can re-enable it when it becomes arch agnostic. CFI_FORWARD_PROTO cannot be turned off by using a config. Please let me know your thoughts otherwise. -- Muhammad Usama Anjum