From: "Kevin Hilman" <khilman@baylibre.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: kernelci@groups.io
Subject: Re: [kernelci] add a new config fragment to kernel/configs
Date: Fri, 12 Oct 2018 14:57:47 +0200 [thread overview]
Message-ID: <7hin27fhkk.fsf@baylibre.com> (raw)
In-Reply-To: <CADYN=9KyT05X_SUPNacmNEkgPi=6Ya9oQB9XRRHOMpAp=tkbgg@mail.gmail.com> (Anders Roxell's message of "Fri, 12 Oct 2018 11:28:30 +0200")
Anders Roxell <anders.roxell@linaro.org> writes:
> I've seen some confusion about what I'm trying to do with all_abi.config (maybe
> not the best name, suggestions are more than welcome). I should of course
> reach out before I started to do this to see if it makes sense to do in the
> first place, but forgot about it, sorry.
>
> Let me try to explain what the idea with this new fragment is about. Adding a
> fragment called all_abi.config (lets stick with this name throughout this
> email) in kernel/configs would be to enable as much as possible. Then we would
> be able to run any test suite with one kernel image.
Thanks for clarifing. To me, that doesn't sound like ABI, and
especially not *all* ABIs. It's just a set of interfaces used by common
test suites. IMO, using ABI is misleading, as when people see that,
they think of all the userspace/kernel interfaces.
> There have been two different paths I've tried:
> 1. add fragments that is needed for kselftest, LTP and libhugetlbfs to the
> all_abi.config to be able to have the same test coverage as we have today in
> LKFT.
>
> 2. do allmodconfig and boot that, sadly that doesn't boot. I've tried to bisect
> the .config file and ended up with a pile of CONFIG_* options that has to be
> enabled/disabled so it booted. The idea was to add these options into the
> all_abi.config so we could do 'make allmodconfig all_abi.config'. There are
> different options that needs to be enabled/disabled between arm64 and x86
> (those are the architectures I've tried on so far).
Having this "minimal boot" defconfig sounds like a good thing to have
independently of the test fragments.
> If we don't think its doable to enable everything into one big kernel, maybe we
> can split up the fragments into different testing fragments like:
> kselftest.config (that should essentially be todays kselftest-merge, but in a
> more visible way), ltp.config, libhugetlbfs.config and so on. The downside here
> would be that random test-suites need to send a patch with the fragments that
> they have to enable for their test suite.
IMO, per test-suite fragments make the most sense, and will much easier
to maintain than one big fragment. It's also more self-documenting, and
test-suite maintainers might be more motivated to keep things up to
date. With one massive fragment, it would have to be well documented
(and kept that way) to understand why various options are present, and
which test suites required them etc.
Kevin
next prev parent reply other threads:[~2018-10-12 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 9:28 add a new config fragment to kernel/configs Anders Roxell
2018-10-12 12:57 ` Kevin Hilman [this message]
2018-10-12 16:39 ` [kernelci] " Mark Brown
2018-10-15 13:01 ` Kevin Hilman
2018-10-15 13:29 ` Mark Brown
2018-10-15 13:40 ` Nicolas Dechesne
2018-10-15 14:05 ` Mark Brown
2018-10-30 17:21 ` Guillaume Tucker
2018-10-31 0:10 ` Kevin Hilman
2018-10-31 7:21 ` Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hin27fhkk.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=anders.roxell@linaro.org \
--cc=kernelci@groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox