From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Corbet Subject: Re: [RFC PATCH v2] Documentation: dev-tools: Add KTAP specification In-Reply-To: <8c06e715-a83e-e8c6-74c3-836831b85cdf@linuxfoundation.org> References: <20211207190251.18426-1-davidgow@google.com> <202112071358.E8E6812D@keescook> <8c06e715-a83e-e8c6-74c3-836831b85cdf@linuxfoundation.org> Date: Fri, 10 Dec 2021 14:05:41 -0700 Message-ID: <87mtl8qifu.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain List-ID: To: Shuah Khan , Kees Cook , David Gow Cc: Brendan Higgins , Tim.Bird@sony.com, shuah@kernel.org, rmr167@gmail.com, guillaume.tucker@collabora.com, dlatypov@google.com, kernelci@groups.io, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan Shuah Khan writes: > On 12/7/21 3:02 PM, Kees Cook wrote: >> On Tue, Dec 07, 2021 at 11:02:51AM -0800, David Gow wrote: >>> From: Rae Moar >>> >>> It does not make any significant additions or changes other than those >>> already in use in the kernel: additional features can be added as they >>> become necessary and used. >>> >>> [1]: https://testanything.org/tap-version-13-specification.html >>> >>> Signed-off-by: Rae Moar >>> Co-developed-by: David Gow >>> Signed-off-by: David Gow >> >> I like it! Thank you so much for suffering through my earlier reviews. >> :) >> >> The only concern I have is wonder what'll be needed to kselftest to >> deal with indentation changes. As long as this can be implemented >> without a subtest knowing it is a subtest, we're good. >> > > A lot of this TAP output is in the wrappers - hopefully it will be okay. > Fingers crossed. :) > >> Reviewed-by: Kees Cook >> > > Looks good to me as well. Thanks for doing this work. > > Reviewed-by: Shuah Khan Would you like me to take this through the docs tree, or do you have other plans for merging? Thanks, jon