From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH V2] selftests: kvm: Remove absent target file References: <20220210172352.1317554-1-usama.anjum@collabora.com> From: Shuah Khan Message-ID: <9198c43b-e5e2-fa58-5862-598dc7019ad6@linuxfoundation.org> Date: Fri, 11 Feb 2022 10:34:58 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit List-ID: To: Paolo Bonzini , Muhammad Usama Anjum , Shuah Khan , Peter Gonda Cc: kernel@collabora.com, kernelci@groups.io, "kernelci.org bot" , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan On 2/10/22 11:56 AM, Paolo Bonzini wrote: > On 2/10/22 19:02, Shuah Khan wrote: >> >> I am fine with the change itself. For this patch: >> >> Reviewed-by: Shuah Khan >> >> However, are we missing a vmx_pi_mmio_test and that test needs to be added. >> >> Just in case the test didn't make it into the 6a58150859fd and the intent >> was to add it - hence the Makefile addition? This can be addressed in >> another patch. Just want to make sure we aren't missing a test. > > This was probably a rebase resolution issue.  The vmx_pi_mmio_test fails in the mainline tree, and is lingering in my tree together with the fix because somebody promised a better fix for it.  I included the TEST_GEN_PROGS_x86_64 line by mistake when rebasing Peter Gonda's test below vmx_pi_mmio_test. > > Thanks for the fix, > > Acked-by: Paolo Bonzini > Paolo, Thank you for explaining the discrepancy. Would you like take this through your tree? This patch depends on commit: de1956f48543e90f94b1194395f33140898b39b2 thanks, -- Shuah