From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DB873DCD92 for ; Wed, 15 Apr 2026 15:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776267768; cv=none; b=J5weW9jpVF/61WXaw2QtdiUWhlCt0psgq3bF3zRzgeY6IoMS/kue/JJRYOOoshRvU5WYzOZzjKOBbWkt6dnW+TjcVpKtjkkzcAhUKVjCVwIyfl4Cl25co013Tr4euVgw80u6fh9EA+fY5k2bI1FL5djebHn0OzTO3LoPz/juuyU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776267768; c=relaxed/simple; bh=dDijZuor1xvmTBogTjju/PAPbY/PQMGI1uljwU/belg=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=XJYDT44br1x1qGKIpqft3DLUhIEjqSILgIumnmrPeWtScl/17H9Od6GDI8RVxs/+69CfjAtwJDTOJASsBeSeAqu7hGm4X7WOh+skeDJDCO3z+enZlR+qLlPLplkOOgB/G4ISn5zBbE++P+huzSl/37w6ybE9900YBnla8zsbCiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=GOI/O6Ak; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="GOI/O6Ak" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso84788385e9.2 for ; Wed, 15 Apr 2026 08:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1776267765; x=1776872565; darn=lists.linux.dev; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3BvjwjAzTjY/jU9mV6i6higD+5qPV14w0YtVebluUHw=; b=GOI/O6AkrPMOAn17QKL7cwsYuqBeQgVwU+c21SgfAHrPW5Qw2Bb+X5E06nKw030jbv 3WBRUjwA+iJ1qlouc4bazz5vOr5LVVBRWGAw3P4ezfPTvXWlvw6mNeNVXOrDSmR/+IkQ NeGuqtKI8KHy9QuOcOcPwJr7xd88jdm4N2NX4PqQQNAqtXePri7YCzkzdo+wlMeTjVaU uKZkCVhLsxn4vCS38+KMqMtEFrQbhvPeP2l1U/n1aG8m01iRwrtQaopLPW6TUGTdeapm wPiV87GE/Cykhitmvwrh0mhFlfK8DOKB4yyQH3VvSZY2n+ov6BQo1EF74otwUkuYRDll zxTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776267765; x=1776872565; h=in-reply-to:references:to:cc:subject:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3BvjwjAzTjY/jU9mV6i6higD+5qPV14w0YtVebluUHw=; b=Ci1IWIRFLPhDi9UaiL7xhuA7DApgQf5bC+nofpzTHAtggFzjzWwDIYUCDygXDAfBX5 OyIh4++bCONVFb3vv6C0YnLwbEwDL/ZmXvnRaxVMQYrAfKbYMxbekQSZPidq/gSgBx81 bWbZ6qw9OZD1uxOpnKKOqHLc39+mR1hfc8cZKHad653LKtucArwNgB8AXWybrMmwWI6J bV4CJObDjezldMZUIYqNGWo8VCNVzUnbod1sdni7D0XVRqg+mHB1Iht87lGG8h7Lqypu wq5fYDX+QJdFZFSyVJ2XSpZjqXfgMMjE78uyI87jQ59k+e9tCF9QP6d5KrebHi+O7iSI /TAg== X-Forwarded-Encrypted: i=1; AFNElJ9L6+8crBfg+uEfCjgy2aCaXCf2XA268m5KOPhEtDnS1h6eHAKS68Sf0zvxQYV7AUu6DDb/3H5gGw==@lists.linux.dev X-Gm-Message-State: AOJu0Yw9AT9SSoh/a0gQbk23jTEOihl0H+ycv9d5nt+ouj5kfPtvqc/L FAl7FVVD2eFyvF65ngkvyJpiufd5u1m4T3xcv9GU6571oPe69qAEqPDiC/I4n+aqoIs= X-Gm-Gg: AeBDieu6/rUmKU44EApZZEuhoHGP5WP46je7V7v8t5g+G1BGXO3gSbuULGSNQfudRiC IkRypG25Mf4/gg/vb8c7DFpsBcpelBo4S7GU0onOGtj7UV7MmFC+rkaj/sl8psJrE+HeTBs8qvl 0hG95gXp3WfQOpvxqBrUTY+NWAyhs7KU2CisGBztpt8D+9e2+rIGhDmR3GEZxbwZN7lH/R7O14c LRKoHDTD3zBqDjAA/ZOR2IY017clzAbq+1/FmK7RyOKP0ze7Y/q6Pin7DmrUUhyqRNPdiDcTzgO hjfaxe/5crvSEFXFD4ZkuL6W8huyWkWJg3WZsx7tR9yk2oMfdzIzVlNxtIjq3I6Qtn9Yc2/8bng YceMdsikP3kojDJkYXwypyOk9u9VW9InmuGogzycM+9s10zX641812Mg+bPlRDKnKzTEEAHk1n5 UMtFsaLotYTA== X-Received: by 2002:a05:600c:19cd:b0:485:17a7:b9c7 with SMTP id 5b1f17b1804b1-488d67e3671mr305346955e9.10.1776267765033; Wed, 15 Apr 2026 08:42:45 -0700 (PDT) Received: from localhost ([2804:7f0:b765:e41:8620:c31f:89a6:1fe0]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2de8c605883sm2995905eec.10.2026.04.15.08.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 08:42:43 -0700 (PDT) Precedence: bulk X-Mailing-List: kernelci@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 15 Apr 2026 12:42:41 -0300 Message-Id: From: =?utf-8?b?UmljYXJkbyBCLiBNYXJsacOocmU=?= Subject: Re: [PATCH 5/6] selftests: Preserve subtarget failures in all/install Cc: "Nathan Chancellor" , "Nicolas Schier" , , , , , , To: "Shuah Khan" , "Mark Brown" , =?utf-8?b?UmljYXJkbyBCLiBNYXJsacOocmU=?= , , "Shuah Khan" X-Mailer: aerc 0.21.0-120-g22b95d38161f References: <20260320-selftests-fixes-v1-0-79144f76be01@suse.com> <20260320-selftests-fixes-v1-5-79144f76be01@suse.com> <3cdf8e79-7c59-4831-9b38-e9c2cef97fe1@linuxfoundation.org> In-Reply-To: <3cdf8e79-7c59-4831-9b38-e9c2cef97fe1@linuxfoundation.org> On Wed Apr 15, 2026 at 12:40 PM -03, Shuah Khan wrote: > On 4/15/26 07:58, Mark Brown wrote: >> On Fri, Mar 20, 2026 at 03:29:20PM -0300, Ricardo B. Marli=C3=A8re wrote= : >>> Track failures explicitly in the top-level selftests all/install loops. >>> >>> The current code multiplies `ret` by each sub-make exit status. For >>> example, with `TARGETS=3Dnet`, the implicit `net/lib` dependency runs a= fter >>> `net`, so a failed `net` build can be followed by a successful `net/lib= ` >>> build and reset the final result to success. >>> >>> Set `ret` to 1 on any non-zero sub-make exit code and keep it sticky, s= o >>> the top-level make returns failure when any selected selftest target >>> fails. >>=20 >> This patch, which is now in mainline as 7e47389142b8, is breaking a >> bunch of CI systems - at least KernelCI, our Arm internal CI and my >> personal stuff. It causes the equivalent of FORCE_TARGETS behaviour in >> the top level Makefile, the prior behaviour where the exit status of the >> top level Makefile ignores failures from individual directories is >> desirable since by default we try to build almost all the selftests but >> between quality issues and build time dependencies it's very common for >> at least one of them to fail. With this commit unless the user has >> configured a more restricted set of selftests it would be surprising if >> we manage to get a successful build and install. >>=20 >> As well as being a poor default due to the very high likelyhood of build >> failures this also has the undesirable effect of causing a build failure >> in one selftest to cause the whole install target to fail, meaning that >> the build failure is escallated to a complete lost of coverge for all >> selftests in common CI usage. >>=20 >> This wasn't showing up in my -next build tests since I set FORCE_TARGETS >> and explicitly choose a restricted set of kselftests which actually >> build with my system and configuration. It was less obvious than it >> should have been with the other systems since they did not expect there >> to be a complete failure to generate a kselftest tarball and variously >> masked the error or reported it in a manner that looked like an >> infrastructure issue. > > I didn't see it when I did test on linux-next and my repo. I did install > to catch problems. > > Sorry for not catching this. We can drop this patch. > >>=20 >> It would be really nice to get to the point where we can reasonably do >> this but we're simply not there at the current time. At the moment if >> people want to see build failures reported at the top level that really >> needs to be opt in, we have FORCE_TARGETS for that. > > Good point - I will go look and see if we document this in kselftest doc > and add it. It's not documented. It would have solved my issue, sorry for overlooking this! > > Mark, would you like to a revert for this? > > thanks, > -- Shuah