From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [kernelci-members] Working with the KernelCI project References: <20200707222342.scrz75265etaqlmd@redhat.com> <863511a8-090a-6ee1-ddce-f32d70458ee8@redhat.com> <1ff4a09c-4529-017c-5b0b-43712575771b@redhat.com> <16397F50C12D08DD.21243@groups.io> <521cc33e-62fc-55c1-aeb2-682007243d97@redhat.com> From: "Nikolai Kondrashov" Message-ID: Date: Thu, 1 Oct 2020 18:58:33 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: To: Dmitry Vyukov Cc: kernelci@groups.io, Guillaume Tucker , Philip Li , kernelci-members@groups.io, nkondras@redhat.com, Don Zickus , syzkaller , =?UTF-8?Q?I=c3=b1aki_Malerba?= On 10/1/20 6:40 PM, Dmitry Vyukov wrote: > On Thu, Oct 1, 2020 at 5:36 PM Dmitry Vyukov wrote: >> >> On Thu, Oct 1, 2020 at 5:12 PM Nikolai Kondrashov >> wrote: >>> >>> On 10/1/20 6:01 PM, Dmitry Vyukov wrote: >>> > On Thu, Oct 1, 2020 at 12:48 PM Nikolai Kondrashov >>> > wrote: >>> >> * Could you move the "dashboard" link out of test's "output_files", and into >>> >> a "misc" field? It won't be presented as a link in Grafana unfortunately, >>> >> but "output_files" is for something which could be useful when downloaded >>> >> (and e.g. re-hosted by KCIDB), and the linked HTML doesn't seem to be. >>> >> Let's deal with the dashboard link issue in >>> >> https://github.com/kernelci/kcidb/issues/93 >>> > >>> > Any suggestions/precedents for the name? >>> > dashboard_link? origin_link? master_link? >>> >>> There's a PR linked which adds "origin_url": >>> https://github.com/kernelci/kcidb/pull/94 >> >> I've implemented all suggested improvements, please check this one: >> https://staging.kernelci.org:3000/d/test/test?orgId=1&var-dataset=playground_kernelci04&var-id=syzkcidb:0a89a7b56db04c21a656 >> >> Here is top-level link, look for the "https:" one: >> https://staging.kernelci.org:3000/d/home/home?orgId=1&refresh=30m&from=now-90d&to=now&var-origin=syzkcidb&var-git_repository_url=All&var-dataset=playground_kernelci04 >> >> Not sure why it's duplicate here, though: >> https://staging.kernelci.org:3000/d/build/build?orgId=1&var-dataset=playground_kernelci04&var-id=syzkcidb:1861b29bc5d979149e290f78e331f38f022ab032 >> both have the same id. If they have the same id, shouldn't they be merged? > > Oh, I submitted it again and now there 3 of them: > https://staging.kernelci.org:3000/d/build/build?orgId=1&var-dataset=playground_kernelci04&var-id=syzkcidb:1861b29bc5d979149e290f78e331f38f022ab032 > > Should they be merged based on id? > > These ones were submitted manually. Do we do dups for the "syzbot" origin? No, we don't do de-duping yet, this is what I'm going to work on next, as I mention in the other message. I agree, this needs to be handled, but we should try to not resubmit without a need, in general :) Nick