From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E1C93FE35 for ; Wed, 6 Dec 2023 16:23:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D9DdyTct" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701879836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bEeLgq3tKfeo+gDdZ+RSrAtJVLsXviPr2EfsX6Jr+7w=; b=D9DdyTctSXhtmt41v5QFC4K6O6BCU3lDq5JXBXGLXnNmkMFThys5lpSeCY7BQD2RHmnT23 mGoGLa1lxh8sqhxXjvO/dPOjJXICI/beEkLX4tGNgXuiJeKxDSe+aFIcndhwBqStTa5phN oOu2hKvKvpPBSFTefFmdipimtOrLJx0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-Cj0m0WYBPQe3hiUTuOi71g-1; Wed, 06 Dec 2023 11:23:55 -0500 X-MC-Unique: Cj0m0WYBPQe3hiUTuOi71g-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40b40234bd5so47904855e9.0 for ; Wed, 06 Dec 2023 08:23:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701879834; x=1702484634; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bEeLgq3tKfeo+gDdZ+RSrAtJVLsXviPr2EfsX6Jr+7w=; b=bE+7b6Ovzjyvaan8KxfO6Bt/SffVm2es2kESvm/DYz4x/MBUlQyQH7jB5p3kd0iE7x qqwYzIT0lLq3msszQgFjTBn5I/kbq23aRSBVajSuq+gCTamERqkDwyxi5Q9dXoBg3KsB Zegzgtg7EbomTjppR4dD0l0yQYv/DHeirSqrfz1yt3glDsYP9kmqQwfNgVOBPAUoTBPJ Fj22YAzJRfsg1O/ZImENZ+yv4bo0AND33qA0DP8E69wMKpcK1XfCItAqHMGV8gqowzvm YftpTG6Wax8sXnvZ3SykYNnVzRuxwk/k4DHOHXxyPzTZjPA7zkdntadqGwzs1rzkV2Z5 To8A== X-Gm-Message-State: AOJu0YzYAhELn1X+Ecb3w9IdBJEHpbO8ARgYgjXDWeJ14plqFMsruC3z D2JkeBaTNuGqlFglBOtyqCD/1/gGjOEZY/V3nzVm/Jn4vNCajLAGZYCMJI6Ez1j3VIe71IUhkKS +3SExksMrQwgwJMIFDOE= X-Received: by 2002:a05:600c:54f1:b0:40c:838:a695 with SMTP id jb17-20020a05600c54f100b0040c0838a695mr664582wmb.174.1701879834186; Wed, 06 Dec 2023 08:23:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwz5MnYWQbASuNlLkNiWsEDxekCPXedq1zH8YxfdaJZ9iXOBY3+Os5iiOyqzo1HtFVVnI73g== X-Received: by 2002:a05:600c:54f1:b0:40c:838:a695 with SMTP id jb17-20020a05600c54f100b0040c0838a695mr664563wmb.174.1701879833914; Wed, 06 Dec 2023 08:23:53 -0800 (PST) Received: from [192.168.0.118] (88-113-27-52.elisa-laajakaista.fi. [88.113.27.52]) by smtp.gmail.com with ESMTPSA id bi12-20020a05600c3d8c00b0040b54335d57sm178976wmb.17.2023.12.06.08.23.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 08:23:53 -0800 (PST) Message-ID: Date: Wed, 6 Dec 2023 18:23:51 +0200 Precedence: bulk X-Mailing-List: kernelci@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 02/10] MAINTAINERS: Introduce V: entry for tests To: David Gow Cc: workflows@vger.kernel.org, Jonathan Corbet , Joe Perches , Andy Whitcroft , Theodore Ts'o , Steven Rostedt , Mark Brown , Shuah Khan , "Darrick J . Wong" , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, Veronika Kabatova , CKI , kernelci@lists.linux.dev References: <20231115175146.9848-1-Nikolai.Kondrashov@redhat.com> <20231205184503.79769-1-Nikolai.Kondrashov@redhat.com> <20231205184503.79769-3-Nikolai.Kondrashov@redhat.com> From: Nikolai Kondrashov In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/6/23 10:12, David Gow wrote: > I'm pretty happy with this personally, though I definitely think we > need the support for tests which aren't just executable scripts (e.g. > the docs in patch 6). > > The get_maintailer.pl bits, and hence the requirement to not include > '@', feel a little bit 'off': I'd rather get_maintainer.pl kept emails > and tests separate by some other means (either having --test _only_ > print tests, not emails at all, or by giving them a prefix like > 'TEST:' or something). But that is diverging more from the existing > behaviour of get_maintainer.pl, so I could go either way. > > Otherwise, this looks pretty good. I'll give it a proper test tomorrow > alongside the other patches. Thanks for the review, David! Yeah, I don't like the '@' bit myself, but it seems to be the path of least resistance right now (not necessarily the best one, of course). I'm up for adding an option to get_maintainer.pl that disables email output, if people like that, though. Nick