kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: joe@perches.com (Joe Perches)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] checkpatch: Remove unnecessary + after {8,8}
Date: Fri, 11 Jul 2014 19:09:30 -0700	[thread overview]
Message-ID: <1405130970.6751.37.camel@joe-AO725> (raw)
In-Reply-To: <20140712020520.GA18611@kroah.com>

There's a useless "+" use that needs to be removed as perl 5.20
emits a "Useless use of greediness modifier '+'" message each
time it's hit.

Reported-by: Greg KH <gregkh@linuxfoundation.org>
Signed-off-by: Joe Perches <joe@perches.com>
---
On Fri, 2014-07-11 at 19:05 -0700, Greg KH wrote:
> Ok, with linux-next I get the same thing:

Thanks Greg.

 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d5ac001..370a974 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2376,7 +2376,7 @@ sub process {
 				"please, no space before tabs\n" . $herevet) &&
 			    $fix) {
 				while ($fixed[$fixlinenr] =~
-					   s/(^\+.*) {8,8}+\t/$1\t\t/) {}
+					   s/(^\+.*) {8,8}\t/$1\t\t/) {}
 				while ($fixed[$fixlinenr] =~
 					   s/(^\+.*) +\t/$1\t/) {}
 			}

  reply	other threads:[~2014-07-12  2:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12  1:21 [PATCH] reformat_with_checkpatch: Add automation to checkpatch Joe Perches
2014-07-12  1:34 ` Greg KH
2014-07-12  1:40   ` Joe Perches
2014-07-12  2:34     ` Greg KH
2014-07-12  9:30     ` Dan Carpenter
2014-07-12 17:55       ` Greg KH
2014-07-12 18:29         ` Joe Perches
2014-07-12 19:28           ` Greg KH
2014-07-13  3:06             ` Joe Perches
2014-07-12  1:39 ` Greg KH
2014-07-12  1:46   ` Joe Perches
2014-07-12  2:01     ` Greg KH
2014-07-12  2:05       ` Greg KH
2014-07-12  2:09         ` Joe Perches [this message]
2014-07-12  2:23           ` [PATCH] checkpatch: Remove unnecessary + after {8,8} Greg KH
2014-08-31 20:58           ` Sören Brinkmann
2014-09-01 16:55         ` [PATCH - resend] " Joe Perches
2014-10-30 11:12           ` Borislav Petkov
2014-10-30 11:15             ` Borislav Petkov
2014-07-12  1:43 ` [PATCH] reformat_with_checkpatch: Add automation to checkpatch Greg KH
2014-07-12  1:50   ` Joe Perches
2014-07-12  1:53 ` Greg KH
2014-07-12  1:57   ` Joe Perches
2014-07-12  2:15     ` Greg KH
2014-07-12  8:08     ` Greg KH
2014-07-12  8:18 ` Greg KH
2014-07-12 10:13   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405130970.6751.37.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).