From: xerofoify@gmail.com (Nicholas Krause)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] usb: Fix switch statement in ohci-tmio.c
Date: Thu, 14 Aug 2014 14:05:56 -0400 [thread overview]
Message-ID: <1408039556-23622-1-git-send-email-xerofoify@gmail.com> (raw)
I am fixing the bug on at the link, https://bugzilla.kernel.org/show_bug.cgi?id=79931.
This bug report states that in the function, tmio_hc_stop the switch has no needed breaks.
Further more this patch fixes this bug by adding the needed breaks.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/usb/host/ohci-tmio.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c
index bb40958..d2b5382 100644
--- a/drivers/usb/host/ohci-tmio.c
+++ b/drivers/usb/host/ohci-tmio.c
@@ -100,12 +100,16 @@ static void tmio_stop_hc(struct platform_device *dev)
switch (ohci->num_ports) {
default:
dev_err(&dev->dev, "Unsupported amount of ports: %d\n", ohci->num_ports);
+ break;
case 3:
pm |= CCR_PM_USBPW3;
+ break;
case 2:
pm |= CCR_PM_USBPW2;
+ break;
case 1:
pm |= CCR_PM_USBPW1;
+ break;
}
tmio_iowrite8(0, tmio->ccr + CCR_INTC);
tmio_iowrite8(0, tmio->ccr + CCR_ILME);
--
1.9.1
next reply other threads:[~2014-08-14 18:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 18:05 Nicholas Krause [this message]
2014-08-14 18:06 ` [PATCH] usb: Fix switch statement in ohci-tmio.c Nick Krause
2014-08-14 18:13 ` Kristofer Hallin
2014-08-14 18:18 ` Nick Krause
2014-08-14 18:36 ` Lucas Tanure
2014-08-14 20:51 ` Valdis.Kletnieks at vt.edu
2014-08-14 21:00 ` Nick Krause
2014-08-14 21:03 ` Mandeep Sandhu
2014-08-14 21:13 ` Nick Krause
2014-08-14 21:38 ` Valdis.Kletnieks at vt.edu
2014-08-14 22:12 ` Nick Krause
2014-08-14 23:46 ` Nick Krause
2014-08-15 2:16 ` Greg Freemyer
2014-08-15 2:29 ` Nick Krause
2014-08-15 2:42 ` Nick Krause
2014-08-15 3:37 ` Nick Krause
2014-08-15 3:42 ` Jaret Flores
2014-08-15 3:43 ` Nick Krause
2014-08-15 4:21 ` Nick Krause
2014-08-14 19:04 ` Tobias Boege
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408039556-23622-1-git-send-email-xerofoify@gmail.com \
--to=xerofoify@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).