From: pebolle@tiscali.nl (Paul Bolle)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Submitting patches question
Date: Mon, 08 Dec 2014 22:16:28 +0100 [thread overview]
Message-ID: <1418073388.2058.64.camel@x220> (raw)
In-Reply-To: <CAOKdMdaZXMP=01yyXMbdpP5yzw3d7_GihvVupaNbB7WN0jfgeQ@mail.gmail.com>
On Mon, 2014-12-08 at 14:05 -0700, Dean Michael Ancajas wrote:
> Hi,
> I have submitted single line patches. I was wondering what is the
> policy on the # of changes per patch? For instance the code below:
>
> if (Index) {
> data = ft1000_read_reg(dev, FT1000_REG_MAG_DPDATAL);
> } else {
> data = ft1000_read_reg(dev, FT1000_REG_MAG_DPDATAH);
> }
>
> the braces are not necessary according to the rules. Should I
>
> A. submit 1 patch for the "if" portion and another for the "else" on
> separate emails (i.e. two patches on separate emails)?
>
> B. 1 patch for the whole thing (considering this is trivial change) ?
>
> C. 2 separate patches but in 1-email only?
B.
Good luck,
Paul Bolle
next prev parent reply other threads:[~2014-12-08 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 21:05 Submitting patches question Dean Michael Ancajas
2014-12-08 21:16 ` Paul Bolle [this message]
2014-12-08 21:24 ` Valdis.Kletnieks at vt.edu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418073388.2058.64.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).