kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: pebolle@tiscali.nl (Paul Bolle)
To: kernelnewbies@lists.kernelnewbies.org
Subject: kobject sample code
Date: Wed, 17 Dec 2014 22:31:21 +0100	[thread overview]
Message-ID: <1418851881.2123.48.camel@x220> (raw)
In-Reply-To: <20141213180104.GA2872@vega.jjdev.com>

On Sat, 2014-12-13 at 13:01 -0500, John de la Garza wrote:
> On Tue, Dec 09, 2014 at 10:26:03AM +0100, Paul Bolle wrote:
> > On Mon, 2014-12-08 at 21:20 -0500, John de la Garza wrote:
> > > I'm looking at samples/kobject/kobject-example.c
> > > 
> > > at line 39 foo is read:
> > > 
> > >         sscanf(buf, "%du", &foo);
> > > 
> > > foo is an int so why is it read using %du not %d?
> > 
> > My reading of lib/vsprintf.c:vsscanf() is that a "%du" format expects
> > "buf" to contain an integer followed by a literal 'u' char. Is that your
> > reading too?
> > 
> After reading the code and the man page for vsscanf, it seems like
> it is not expecting the 'u', but rather ignores it.

The manpage _probably_ describes intended behavior. But I'm not sure
whether the kernel's vsscanf() tries to emulate it all that faithfully.
(And, besides, that manpage would gain quite a bit with a few examples.)
Anyhow, the net effect of "%du" appears to be to ignore any non digit
trailing input. So I think you're reading the code correctly.

> vsscanf is a bit complicated for me, so I may be missing something.

I wouldn't have bothered replying if I had not noticed
https://lkml.org/lkml/2014/12/17/386 . You might like to have a look at
that patch. My primary observation is that its commit explanation is not
very helpful. (That's why I CC-ed Ratislav.)


Paul Bolle

  reply	other threads:[~2014-12-17 21:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09  2:20 kobject sample code John de la Garza
2014-12-09  9:26 ` Paul Bolle
2014-12-13 18:01   ` John de la Garza
2014-12-17 21:31     ` Paul Bolle [this message]
2014-12-17 23:35       ` Rastislav Barlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418851881.2123.48.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).