From: waltfeasel@gmail.com (Walt Feasel)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH 2/7] security: apparmor: apparmorfs.c Blank line after declarations
Date: Sat, 26 Nov 2016 03:43:20 -0500 [thread overview]
Message-ID: <1480149805-18736-3-git-send-email-waltfeasel@gmail.com> (raw)
In-Reply-To: <1480149805-18736-1-git-send-email-waltfeasel@gmail.com>
Make style modifications for:
WARNING: Missing a blank line after declarations
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
security/apparmor/apparmorfs.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c
index 62aac35..6b9ace3 100644
--- a/security/apparmor/apparmorfs.c
+++ b/security/apparmor/apparmorfs.c
@@ -57,6 +57,7 @@ static int mangle_name(char *name, char *target)
*t = 0;
} else {
int len = 0;
+
for (; *name; name++) {
if (isalnum(*name) || isspace(*name) ||
strchr("/._-", *name))
@@ -240,6 +241,7 @@ static int aa_fs_seq_profile_open(struct inode *inode, struct file *file,
static int aa_fs_seq_profile_release(struct inode *inode, struct file *file)
{
struct seq_file *seq = (struct seq_file *) file->private_data;
+
if (seq)
aa_put_replacedby(seq->private);
return single_release(inode, file);
@@ -249,6 +251,7 @@ static int aa_fs_seq_profname_show(struct seq_file *seq, void *v)
{
struct aa_replacedby *r = seq->private;
struct aa_profile *profile = aa_get_profile_rcu(&r->profile);
+
seq_printf(seq, "%s\n", profile->base.name);
aa_put_profile(profile);
@@ -272,6 +275,7 @@ static int aa_fs_seq_profmode_show(struct seq_file *seq, void *v)
{
struct aa_replacedby *r = seq->private;
struct aa_profile *profile = aa_get_profile_rcu(&r->profile);
+
seq_printf(seq, "%s\n", aa_profile_mode_names[profile->mode]);
aa_put_profile(profile);
@@ -295,6 +299,7 @@ static int aa_fs_seq_profattach_show(struct seq_file *seq, void *v)
{
struct aa_replacedby *r = seq->private;
struct aa_profile *profile = aa_get_profile_rcu(&r->profile);
+
if (profile->attach)
seq_printf(seq, "%s\n", profile->attach);
else if (profile->xmatch)
@@ -362,6 +367,7 @@ void __aa_fs_profile_rmdir(struct aa_profile *profile)
for (i = AAFS_PROF_SIZEOF - 1; i >= 0; --i) {
struct aa_replacedby *r;
+
if (!profile->dents[i])
continue;
@@ -408,6 +414,7 @@ int __aa_fs_profile_mkdir(struct aa_profile *profile, struct dentry *parent)
if (!parent) {
struct aa_profile *p;
+
p = aa_deref_parent(profile);
dent = prof_dir(p);
/* adding to parent that previously didn't have children */
@@ -419,6 +426,7 @@ int __aa_fs_profile_mkdir(struct aa_profile *profile, struct dentry *parent)
if (!profile->dirname) {
int len, id_len;
+
len = mangle_name(profile->base.name, NULL);
id_len = snprintf(NULL, 0, ".%ld", profile->ns->uniq_id);
@@ -662,6 +670,7 @@ static struct aa_profile *next_profile(struct aa_namespace *root,
struct aa_profile *profile)
{
struct aa_profile *next = __next_profile(profile);
+
if (next)
return next;
@@ -683,6 +692,7 @@ static void *p_start(struct seq_file *f, loff_t *pos)
struct aa_profile *profile = NULL;
struct aa_namespace *root = aa_current_profile()->ns;
loff_t l = *pos;
+
f->private = aa_get_namespace(root);
/* find the first profile */
--
2.1.4
next prev parent reply other threads:[~2016-11-26 8:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-26 8:43 [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods Walt Feasel
2016-11-26 8:43 ` [PATCH 1/7] security: apparmor: apparmorfs.c Multiple blank lines Walt Feasel
2016-11-26 8:43 ` Walt Feasel [this message]
2016-11-26 8:43 ` [PATCH 3/7] security: apparmor: apparmorfs.c Space after cast Walt Feasel
2016-11-26 8:43 ` [PATCH 4/7] security: apparmor: apparmorfs.c WARN_ON vs BUG_ON Walt Feasel
2016-11-26 8:43 ` [PATCH 5/7] security: apparmor: apparmorfs.c Align parenthesis Walt Feasel
2016-11-26 8:43 ` [PATCH 6/7] security: apparmor: apparmorfs.c Comparison to NULL Walt Feasel
2016-11-26 8:43 ` [PATCH 7/7] security: apparmor: apparmorfs.c Line continuations Walt Feasel
2016-11-26 11:05 ` [PATCH 0/7] security: apparmor: apparmorfs.c Checkpatch mods Greg KH
2016-11-26 16:56 ` Walt Feasel
2016-11-26 17:19 ` Greg KH
2016-11-26 18:02 ` Walt Feasel
2016-11-26 20:40 ` Greg KH
2016-11-26 21:28 ` Bjørn Mork
2016-11-26 22:41 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480149805-18736-3-git-send-email-waltfeasel@gmail.com \
--to=waltfeasel@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).