From mboxrd@z Thu Jan 1 00:00:00 1970 From: waltfeasel@gmail.com (Walt Feasel) Date: Sat, 26 Nov 2016 03:43:22 -0500 Subject: [PATCH 4/7] security: apparmor: apparmorfs.c WARN_ON vs BUG_ON In-Reply-To: <1480149805-18736-1-git-send-email-waltfeasel@gmail.com> References: <1480149805-18736-1-git-send-email-waltfeasel@gmail.com> Message-ID: <1480149805-18736-5-git-send-email-waltfeasel@gmail.com> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org Make style modifications for: CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() Signed-off-by: Walt Feasel --- Not sure if correct use. Seems if copy_size > alloc_size it is corrected by writing partial data and return an error. security/apparmor/apparmorfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index c5701f3..d759c78 100644 --- a/security/apparmor/apparmorfs.c +++ b/security/apparmor/apparmorfs.c @@ -87,7 +87,7 @@ static char *aa_simple_write_to_buffer(int op, const char __user *userbuf, { char *data; - BUG_ON(copy_size > alloc_size); + WARN_ON(copy_size > alloc_size); if (*pos != 0) /* only writes from pos 0, that is complete writes */ -- 2.1.4