From mboxrd@z Thu Jan  1 00:00:00 1970
From: Valdis.Kletnieks@vt.edu (Valdis.Kletnieks at vt.edu)
Date: Mon, 08 Sep 2014 14:08:24 -0400
Subject: Bug Patch
In-Reply-To: Your message of "Mon, 08 Sep 2014 06:36:34 -0400."
	<540D86B2.6080505@gmail.com>
References: <540D86B2.6080505@gmail.com>
Message-ID: <15552.1410199704@turing-police.cc.vt.edu>
To: kernelnewbies@lists.kernelnewbies.org
List-Id: kernelnewbies.lists.kernelnewbies.org

On Mon, 08 Sep 2014 06:36:34 -0400, nick said:

> Found a bug and attempted to fix it
>  			sub_skb = dev_alloc_skb(nSubframe_Length + 12);
> +			if (!sub_skb)
> +				return -ENOMEM;

Nick - we've told you before to research this stuff more fully before
posting patches.  As others have pointed out, there's exactly one caller, who
wants a different return on error.

For bonus points - explain why you're returning a -ENOMEM from
a function that's declared as 'static u8 parse_subframe(...'.

This is *NOT* how you convince us that you should be allowed anywhere near
kernel code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140908/c4a2a560/attachment.bin