From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0714EC433E1 for ; Thu, 27 Aug 2020 16:34:52 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABBAD207DF for ; Thu, 27 Aug 2020 16:34:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="PLl82qTU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABBAD207DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1kBKrB-0000lw-Dj; Thu, 27 Aug 2020 12:34:33 -0400 Received: from mout.gmx.net ([212.227.17.20]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kBKr8-0000lh-MS for kernelnewbies@kernelnewbies.org; Thu, 27 Aug 2020 12:34:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1598546063; bh=YT/L8a5thmgqhYsiGI7Y4A/0zuwVIwE0Hozyni9FXOU=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=PLl82qTUURYbQeNFBVH6ycrFLLHUcfY3fsi+39q9CJGao8XkBSsSeZCRUKTdDucBK kUW5TdzC0yyR9MPFhGl3PwN4VJvxJxabezMgT0QwzSVWHJnMK60tUXee5X5mbZMvrp qf2zPFlWAwYHNW5QebvZpzHiGGT4fH5btlyNK6p4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([84.179.245.142]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N79u8-1kh1T12pTw-017UQd; Thu, 27 Aug 2020 18:34:23 +0200 Date: Thu, 27 Aug 2020 18:34:45 +0200 From: "Thomas Schmitt" To: kernelnewbies@kernelnewbies.org Subject: Re: Please give advise about my first patch attempt References: In-Reply-To: Message-Id: <1623736283545418611@scdbackup.webframe.org> X-Provags-ID: V03:K1:bM4ykQUkDIKo0GzKRBV2goxvftjw8V3Vd/uHCpNVYUBjzxFRUQf kfWOsmRd3bh1wpEgsmq7Y641+Ru+EpMF4PneQAWHW94cgIgC3FS6PM2ItMVb67CxnI2/SIf xsDYDzWjDxR8aQKLk+hs9CGnX3XYHm+9RHKQ3Z1FMaEwtIr2wkzhjB3BJwbJRrFIVMa9LnH XQsoxtxt3Rpk5jhG9Yfpw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Ut+EN0Q3CsA=:mmuKfHjwLRw10RIP+06nsG eMCfDeBFKFnVr+evNSd7egQ3rYwykjwRV2AECetq98n5rRnE3MK+lxc/jJCf39nG+gMaHOfXN 8y1yEck6Y0FcNmufn+Q7IrrR5FqDMrrN8QhzFI6frD2pxqKGtjJ+erOMB/Ra/pJYkXdHH0zxf mnoRxishvwv12VcLhAP79ccGqGrriicGE2Cxcs+bSXjGilsHE35NVXdad2qVq5Osd2zLNGu7W nFpQv7VUJGnL6iqx75jFGb8rw710qY5w/rrwvcoWLo8q8th/9xJ0PTMXKhq7lBlAGLa+3vICs EZbZ41lQgjt3+ndSMLbyJWpunAGbF6yUJqOxNrGc8WSAulqOIFkpd2cB51i/b/PfAUdIXamUx 4W+l28YUvKHdgAkKcrIBCsir3P1RK55+XcGTTE7De6zxGt2H6Uuj9qL3gKW2veD+wxMU1Choq xNzLjnJxGw1mF8bcpQQGO/H3SGjPpfO+sZSIw80S4yHxguP292o26xrpiAGxNlDHmFhOWdg9d z7WQEyzC6w4+D52woE9jljQMyt9kms3OYp/MHgFwNAfFZ8F1dhcDmAoCS55bQkgETTJ2/WJVe gb6cvlKm70DEnmvKk1Fbm6q7PeboxmkHh3yCIQk376NCp0y530gQ3vEdB7CfmjhZ4qMUH/KQC 4NVo4DyiR5D64T9Nj/V3Zib4hDUTWlDSpmy6FNC78hvckCV8SyEjycYrTKW/uzEFN3RVhwV29 nXBRkrgequtT45ltESGINiqanIHGpKx9nsD49srLKKhxNDFPr6Eqmmq30+awo+y72WRScFf0I GEyE2qAMqEaX+LcJO+20PUiZNRDNiUXd5a35NyhaCvtrNk84NmuTsjSj1XP4dsy8hRE1Qk3Mx wXZeX+BEqqhhE/Kk9THDFkILERGsMP+jKc2t8mxC2PbOn8yNXWZ/ay9DwY7LH+xIjGWd8z+Nl WGF+GodvZmpR7zPhN1Rn3CIJEWHmxsQSmapJY3BgGOwZFvyjDRa9HYJce/UIbjR47+EwG7U/T DeI5nxaAxG1f9pHD8dA75Zr3KvbWvwmeXKOnyX4cmxHROA3iETozit+1mShRmNGDQjsZc5DvW 8FFAf8EIzwh0kXhW8J3A+UGIPTAwh3grI/NXXch3XDuEQoQROcAGTv/Ce4eNkXHAXu7f4dTtZ 9UC0nQHi/wk7fY1Z+lDsGpJaNn07eJsDN11iP0hEfsxjOvaQq1gNETDx01YmprE1rKu8ENu/R Id451dFsOJGMfsTJi Cc: lukas.bulwahn@gmail.com, garritfranke@gmail.com, greg@kroah.com X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org Hi, Lukas Bulwahn wrote: > Just take all maintainers as recipients. > axboe@kernel.dk linux-kernel@vger.kernel.org jejb@linux.ibm.com > martin.petersen@oracle.com linux-scsi@vger.kernel.org Really that loudly ? Ain't linux-kernel@vger.kernel.org too general ? > It is probably best to base it on v5.9-rc2 Done. The patch was accepted by git apply. git diff looks good. (There were indeed changes in cdrom.c and cdrom.h. It's not that dead. :)) It compiles, but does not boot: [1.099627] nvme nvme0: failed to set APST feature (-10) Gave up waiting for root filesystem device I booted the 5.8 kernel and was happy to see my SSD well and alive. Then i reverted my changes, compiled and installed the original 5.9-rc2. Same boot failure (it would have been astonishing if not). So i cannot test on 5.9-rc2. (Had to manually rename vmlinuz-5.9.0-rc2-ts and initrd.img-5.9.0-rc2-ts before update-grub was willing to create a .cfg which does not boot it by default. Eww ... whenever i leave the trodden path ...) > check if it cleanly applies on the latest linux-next I read https://www.kernel.org/doc/man-pages/linux-next.html and did without really knowing why: $ git remote add linux-next git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git $ git fetch linux-next ... * [new branch] akpm -> linux-next/akpm * [new branch] akpm-base -> linux-next/akpm-base * [new branch] master -> linux-next/master * [new branch] pending-fixes -> linux-next/pending-fixes * [new branch] stable -> linux-next/stable * [new tag] next-20200827 -> next-20200827 $ git checkout master ... $ git remote update ... Fetching linux-next $ git checkout -B linux-next-20200827-ts-issue-2 next-20200827 Switched to a new branch 'linux-next-20200827-ts-issue-2' $ git apply /home/thomas/v5.9-rc2_issue_2.git.diff $ Compilation succeeds and it boots. dd if=/dev/sr0 bs=2048 count=1 of=/dev/null dd if=/dev/sr1 bs=2048 count=1 of=/dev/null both succeed starting from open tray with a readable medium in it. So shall i base my patch on next-20200827 ? ------------------------------------------------------------------------- > > Please also tell me if my mailer (used with this mail) would cause > > problems. > I suggest [...] git send-email ... I am not sure whether i can get git send-email to work due to local network issues. My free software mails go out by a primitive SMTP client which gets fed with plain text files, usually created by vim. Thus i ask whether my mails show any properties which would hamper acceptance of a patch, which i would generate by git format-patch. (I look at patches in https://marc.info/?l=linux-scsi and will try to mimick them in my text file as good as possible.) > I cannot comment on the technical stuff, but that what the mailing list is > good for Shall i mention that i am developer of libburn since 2006, which on Linux operates optical drives from userspace via ioctl(SG_IO) ? > maybe you are the > next maintainer for CDROM drivers when you continue to test CDROM :) Urm. This risk exists by having 7 more cdrom and sr problems fixed in my local production kernel 4.19, plus 2 of fs/iso9660. But my clumsiness with community and git will hopefully prevent that. In general it is not easy to test CDROM beyond sr, because the non-sr devices are very outdated and need bus hardware which i don't have any more since years. But sr drives are capricious enough to be fun. ------------------------------------------------------------------------- Garrit Franke wrote: > In a recent Patch of mine, Greg nicely pointed out that commits should > have a standard format across mailing lists: sha ("Commit Message"). > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2235132.html Applied to my commit message draft. Thanks for pointing out. Greg KH wrote: > That is also documented in the ever-growing submitting patches document In next-20200827 it's line 930 of Doc*/process/submitting-patches.rst . I now plan to write: Commit 210ba1d1724f ("[SCSI] sr: update to follow tray status correctly") of january 2008 switched sr_drive_status() away from indirectly using ... By commit 96bcc722c47d ("[SCSI] sr: report more accurate drive status after closing the tray.") of july 2008 it now returns CDS_DRIVE_NOT_READY ... Have a nice day :) Thomas _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies