From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F2FC433E9 for ; Thu, 3 Sep 2020 15:59:27 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB5E32072A for ; Thu, 3 Sep 2020 15:59:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="IDFK0bXs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB5E32072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1kDrda-0007wW-JV; Thu, 03 Sep 2020 11:58:58 -0400 Received: from mout.gmx.net ([212.227.15.19]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kDrdX-0007wC-H6 for kernelnewbies@kernelnewbies.org; Thu, 03 Sep 2020 11:58:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599148728; bh=yAq62toLv35pyJNd5T3cheekSdPknDn7VPLbDNCTZgE=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=IDFK0bXs4OOFKDC+YQ5C9Sa/0v3VjLGJY3aUWqjrXDaufY7b6plvFt6aQsLRE3Q8f uhkAenCYe4ONtmWgHTvFJznrY55a6Y61m3zhw9R72kfnDxAPHGzB3kmOFcNya34OqG Wdh3pBUNsxdSzdj/hjutC8Saa7dkA5Uc022hrnVg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([84.179.245.142]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MCsU6-1kMhK41iYy-008sKr; Thu, 03 Sep 2020 17:58:48 +0200 Date: Thu, 03 Sep 2020 17:59:28 +0200 From: "Thomas Schmitt" To: kernelnewbies@kernelnewbies.org Subject: Re: Please give advise about my first patch attempt References: <8257736897954643869@scdbackup.webframe.org> In-Reply-To: <8257736897954643869@scdbackup.webframe.org> Message-Id: <16413737425884866123@scdbackup.webframe.org> X-Provags-ID: V03:K1:U9D60gEhzzK1VtEMQaOGXX4aDxPCf+lEp/ElnpY2U8xoSG9jAxR ONvLc9AelT1tLErWGSk8KdjCufH7otq3bEdN6IVXCYjIpOubecPcvmlm8o9LlmsJU/3J4Vl VeI4+gpPHTMDmmZ5JkhN/IqFvdkmjlZ96PW3Ud41D/Kt3ESFmQJksNhtUkyzyjMGNWFYiV/ jx0x+845vlc/pAQuM8gJQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:RKSUClizqeA=:vWuBH+TlgZA6c4abnJiNQD sBDMKsNV4HOHkMTu+7eTji3Aurv7hxmV94ffulEE4LIdxvqv1HGivezn+oVPnnGo3Ycjp6vKv nGocWMSldcXv3YpXBzfydgXbURJM/AUZdtaSeMvXTx9eSSasCe9sMxh4wx6Q4+EVPCOJ+9Y2s UTMywvOu9DZHMyzcp/xdd+L8hC2vae02AzkPBmj8wmZReT6iqa18lukpJh8BrcB4WAGTzXUku nxeZ9CbeSzdCigwXNulL22pvuU4b4nAyeZw86fHE98vcwxKxKJGQXE4V5CVYKNCQfk4edBm+H mYkGCbqTlqKsn8T6R6XxJEn6CriIuO9XpJs0ponUFnvibsdEL7KM9RpeG/qtIpMg++41wTdNK 4W8EdnB5S20ACfZfmuW121fREn8L/jgves/b8Ssx2EocxUuMOrREbqEfxDQZZnbXZOzG7M5B1 lF9XWx+EU9zBy53WTxPq+cH1IMRvK17Jb+ROTZ998DMboaXjotp2t9iyaWgCElelrs+fVWsWo KIyQ7AEKhAGP5WGpiT6h1eBbm+xmDbcUxoJhrhilbCWUmMX3X3I9ECyvIUik7fMF39YgEtkn/ FSHAkFCQydMnzolrEHmsvx+yTRi4Qsu/xYFDcN6Wex6PPZFPG8qe+5Z9ao+RPN1gE+LLSl24I arfvL1oSerIDHMK3DVm5sSSNdFuv0U8jF9Yteo+eOmePy6IH6NrCvzRuS0+WUqMurzs2ORF2d 9UItpFmjrnlrgU6ar0CWInWHLHVrL36kmbvTqbClCdkfT1LJlnu7Oi1CUOt9WItZwSKmC2Ay0 lgYp+teJgBkKs99uNiD1KeDH5ZGGnbkzjScEPJC4RldkfL2rnVt/jtaZS6Xo0enTiq45ocGsi g/KW792LrYZRV0VenMB9zfyJ02/CAqcU2QfAvvlVNnYpV2FWyMVuz0Pd8zIyddR6hx4YL6MZa Qn/NV+OFauiudktYCph5l1AsqZV+rtdVnOjj2mA9sjnEQ6nEnf9tZuIp5rES635XGNIO1P5Qy BVCYsFRavbtbEeTOh9natS+W4W8C8NogdnbZlG24H2uIrvZNdawPQk+U/HSOJgYlLl1UbPXly +6zjvR/ZFEelt0fOQKQuTd/K/9bqUnVZk6tYQm2N+hv2W+tZ0f/owG8lam40b57E41yGxQKL8 03X6/ufvYzDmnZAmwFadzDvwb4jPSsZte+5Pai+fjvqIKzR2MR5JoFglWBec3q5TfYhiwCqiw At1We7zKEKFmsX77y7800OjwB9E7YcoIv3US5GQ== Cc: lukas.bulwahn@gmail.com, garritfranke@gmail.com, greg@kroah.com X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org Hi, i'm back at work with my patch for automatic CD loading, but the target moves faster than i can follow. Meanwhile the sr part of my change plays on a fresh construction site of linux-scsi: https://lore.kernel.org/linux-scsi/730eced4-c804-a78f-3d52-2a448dbd1b84@interlog.com/T/#t "rework check_disk_change()" 2020-09-02 14:11 Christoph Hellwig Currently our plans overlap by [PATCH 17/19] "sr: use bdev_check_media_change" although they do not (yet) really conflict https://lore.kernel.org/linux-scsi/730eced4-c804-a78f-3d52-2a448dbd1b84@interlog.com/T/#m9d4c4b6145ed41d6467f2dc4728d6fd0345e94f1 It seems unwise to propose changes while Christoph Hellwig is actively working on the same code. (And i don't even know where to get the git branch with such a recent change when it is committed.) What is the socially acceptable way to coordinate plans with him ? - Shall i patiently wait until he is done with cdrom and sr ? - Shall i announce my interest in fixing automatic tray loading and other things in a brief mail to the list ? - Shall i post my patches (*) as they are and just wait for instructions ? (*) Studying Christoph's work in linux-scsi brought me to the prediction that they will want separate patches for cdrom and sr. Also i reworked my implementation along his design pattern of factoring out and exporting functions and then calling them where beneficial. (I.e. my -EDEADLK hack is dead. Long live cdrom_handle_open_tray(). Larger cdrom patch, but also nicer looking code.) Have a nice day :) Thomas _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies