From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D328BC43381 for ; Tue, 12 Mar 2019 18:41:37 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C05A2077B for ; Tue, 12 Mar 2019 18:41:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C05A2077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.91) (envelope-from ) id 1h3mKe-0004Dc-6S; Tue, 12 Mar 2019 14:40:56 -0400 Received: from omr2.cc.ipv6.vt.edu ([2607:b400:92:8400:0:33:fb76:806e] helo=omr2.cc.vt.edu) by shelob.surriel.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h3mKb-0004DN-2a for kernelnewbies@kernelnewbies.org; Tue, 12 Mar 2019 14:40:54 -0400 Received: from mr4.cc.vt.edu (mr4.cc.vt.edu [IPv6:2607:b400:92:8300:0:7b:e2b1:6a29]) by omr2.cc.vt.edu (8.14.4/8.14.4) with ESMTP id x2CIeic2002214 for ; Tue, 12 Mar 2019 14:40:44 -0400 Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mr4.cc.vt.edu (8.14.7/8.14.7) with ESMTP id x2CIed32022144 for ; Tue, 12 Mar 2019 14:40:44 -0400 Received: by mail-qk1-f197.google.com with SMTP id e25so2979976qkj.12 for ; Tue, 12 Mar 2019 11:40:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:date:message-id; bh=fRGT36S8W4aBoZ9HNQ5mYeWviWFEj/ul3Ym8pkqOFcs=; b=Ew3fzouPjoxDTMqv8uuwfJ2uWietOiCbve7njYpvds7IA/r92XB/cwyah8K0HPA51i dGj+Tzktv6qoOPjrh47om3tUnqytph/Bkhe2zzhVUjXSqeWzt3LyINug7GPzawsKjjlR 5bp6DVTLcAiwns5gEYss7/B7M936T0oYJ0oF0AXWsqI0wumKRjdH0x0qOZLSktcZ6hGE iPS6SJwH+3XK+jznDBHjDiBgTXVAYGOVw/Mrnsqx3MEsIOIOJzfv4Gk+TkPvlUMiwFys lAymGjs+FY9yQ+rjR40vtJ1vvG3kTmx5DT1EF8qErjemwqkRPnGpHNYqw7RTZdOvYZOt LQEA== X-Gm-Message-State: APjAAAVtbncYjpnNoeAt1U9i2jixxcU/jlYT1HriQpSnv6JSqUBryeMZ utubuNN5obajh8Kp1EdeRKV18nRDcBeIkDfoUgCwwZHZmEMY8Xy7U6rYTpLDY8Gjz7/aLHXXDch pQRito5rGjJpWBEICTC46Ga4IdfYka5+/Zgl9ZFo= X-Received: by 2002:ac8:354e:: with SMTP id z14mr31686715qtb.131.1552416039236; Tue, 12 Mar 2019 11:40:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqyZO5pDuO2oePqq8Ujvc2nb0+5bTUTTCkc+G98vmBTqlGGb9ThYZdTnRHjKGDbT9lurfrUCiw== X-Received: by 2002:ac8:354e:: with SMTP id z14mr31686703qtb.131.1552416039082; Tue, 12 Mar 2019 11:40:39 -0700 (PDT) Received: from turing-police ([2601:5c0:c001:4341::3b7]) by smtp.gmail.com with ESMTPSA id z14sm1280293qta.45.2019.03.12.11.40.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 11:40:37 -0700 (PDT) From: valdis.kletnieks@vt.edu X-Google-Original-From: Valdis.Kletnieks@vt.edu X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: arshad hussain Subject: Re: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c In-reply-to: References: Mime-Version: 1.0 Date: Tue, 12 Mar 2019 14:40:36 -0400 Message-ID: <17926.1552416036@turing-police> Cc: linux-erofs@lists.ozlabs.org, Gao Xiang , miaoxie@huawei.com, Gao Xiang , kernelnewbies X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Tue, 12 Mar 2019 23:33:47 +0530, arshad hussain said: > Re-sending. Previous patch I put in very old kernel-newbies address. > > Subject: [PATCH 1/1] staging: erofs: Add function comment for > erofs/super.c > > This patch adds functions comment for file erofs/super.c in > sphinx format. > > Signed-off-by: Arshad Hussain > --- > drivers/staging/erofs/super.c | 133 ++++++++++++++++++++++++++++++++++++++++ +- > 1 file changed, 130 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/erofs/super.c b/drivers/staging/erofs/super.c > index 15c784fba879..6d2b93d94839 100644 > --- a/drivers/staging/erofs/super.c > +++ b/drivers/staging/erofs/super.c > @@ -30,6 +30,11 @@ static void init_once(void *ptr) > inode_init_once(&vi->vfs_inode); > } > > +/* Actually, if you're trying to do sphinx/kerneldoc format, the first line of the block comment should be '/**' with two asterisks. Also, all kernel patches should be cc'd to linux-kernel@vger.kernel.org as well as the maintainers and subsystem lists. _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies