Porting problem: ndo_set_multicast_list removed

Porting problem: ndo_set_multicast_list removed

[Woody Wu]

Hi, list

I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
kernel, the ndo_set_multicast_list method in the net_device_ops had been
removed. What's the story behind?  Can I simply ignore this method
defined in an old driver?

Please also help to check the below code, is the list of the operations
defined for my driver enough or not?

const struct net_device_ops ax_netdev_ops = {
	.ndo_open		= mydriver_open,
	.ndo_stop		= mydriver_close,
	.ndo_start_xmit		= mydriver_start_xmit,
	.ndo_get_stats		= mydriver_get_stats,
	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
	.ndo_set_mac_address 	= mydriver_set_mac_address,
};

Thanks in advance.

-- 
woody
I can't go back to yesterday - because I was a different person then.

Porting problem: ndo_set_multicast_list removed

[Eric Dumazet]

On Tue, 2012-12-25 at 00:30 +0800, Woody Wu wrote:
> Hi, list
> 
> I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
> kernel, the ndo_set_multicast_list method in the net_device_ops had been
> removed. What's the story behind?  Can I simply ignore this method
> defined in an old driver?
> 
> Please also help to check the below code, is the list of the operations
> defined for my driver enough or not?
> 
> const struct net_device_ops ax_netdev_ops = {
> 	.ndo_open		= mydriver_open,
> 	.ndo_stop		= mydriver_close,
> 	.ndo_start_xmit		= mydriver_start_xmit,
> 	.ndo_get_stats		= mydriver_get_stats,
> 	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
> 	.ndo_set_mac_address 	= mydriver_set_mac_address,
> };
> 
> Thanks in advance.
> 

Take a look at :

commit afc4b13df143122f99a0eb10bfefb216c2806de0
Author: Jiri Pirko <jpirko@redhat.com>
Date:   Tue Aug 16 06:29:01 2011 +0000

    net: remove use of ndo_set_multicast_list in drivers
    
    replace it by ndo_set_rx_mode
    
    Signed-off-by: Jiri Pirko <jpirko@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

Porting problem: ndo_set_multicast_list removed

[Woody Wu]

On Mon, Dec 24, 2012 at 11:16:27AM -0800, Eric Dumazet wrote:
> On Tue, 2012-12-25 at 00:30 +0800, Woody Wu wrote:
> > Hi, list
> > 
> > I am porting an ethernet driver from 2.6.x to 3.7.1.  I found in the new
> > kernel, the ndo_set_multicast_list method in the net_device_ops had been
> > removed. What's the story behind?  Can I simply ignore this method
> > defined in an old driver?
> > 
> > Please also help to check the below code, is the list of the operations
> > defined for my driver enough or not?
> > 
> > const struct net_device_ops ax_netdev_ops = {
> > 	.ndo_open		= mydriver_open,
> > 	.ndo_stop		= mydriver_close,
> > 	.ndo_start_xmit		= mydriver_start_xmit,
> > 	.ndo_get_stats		= mydriver_get_stats,
> > 	/*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
> > 	.ndo_set_mac_address 	= mydriver_set_mac_address,
> > };
> > 
> > Thanks in advance.
> > 
> 
> Take a look at :
> 
> commit afc4b13df143122f99a0eb10bfefb216c2806de0
> Author: Jiri Pirko <jpirko@redhat.com>
> Date:   Tue Aug 16 06:29:01 2011 +0000
> 
>     net: remove use of ndo_set_multicast_list in drivers
>     
>     replace it by ndo_set_rx_mode
>     
>     Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> 

Thanks for the info!

-- 
woody
I can't go back to yesterday - because I was a different person then.