From: narkewoody@gmail.com (Woody Wu)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Porting problem: ndo_set_multicast_list removed
Date: Tue, 25 Dec 2012 07:47:14 +0800 [thread overview]
Message-ID: <20121224234713.GA6756@zuhnb712> (raw)
In-Reply-To: <1356376587.20133.9693.camel@edumazet-glaptop>
On Mon, Dec 24, 2012 at 11:16:27AM -0800, Eric Dumazet wrote:
> On Tue, 2012-12-25 at 00:30 +0800, Woody Wu wrote:
> > Hi, list
> >
> > I am porting an ethernet driver from 2.6.x to 3.7.1. I found in the new
> > kernel, the ndo_set_multicast_list method in the net_device_ops had been
> > removed. What's the story behind? Can I simply ignore this method
> > defined in an old driver?
> >
> > Please also help to check the below code, is the list of the operations
> > defined for my driver enough or not?
> >
> > const struct net_device_ops ax_netdev_ops = {
> > .ndo_open = mydriver_open,
> > .ndo_stop = mydriver_close,
> > .ndo_start_xmit = mydriver_start_xmit,
> > .ndo_get_stats = mydriver_get_stats,
> > /*.ndo_set_multicast_list = mydriver_set_multicast_list,*/
> > .ndo_set_mac_address = mydriver_set_mac_address,
> > };
> >
> > Thanks in advance.
> >
>
> Take a look at :
>
> commit afc4b13df143122f99a0eb10bfefb216c2806de0
> Author: Jiri Pirko <jpirko@redhat.com>
> Date: Tue Aug 16 06:29:01 2011 +0000
>
> net: remove use of ndo_set_multicast_list in drivers
>
> replace it by ndo_set_rx_mode
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
>
Thanks for the info!
--
woody
I can't go back to yesterday - because I was a different person then.
prev parent reply other threads:[~2012-12-24 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-24 16:30 Porting problem: ndo_set_multicast_list removed Woody Wu
2012-12-24 19:16 ` Eric Dumazet
2012-12-24 23:47 ` Woody Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121224234713.GA6756@zuhnb712 \
--to=narkewoody@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).