From: arlie@worldash.org (Arlie Stephens)
To: kernelnewbies@lists.kernelnewbies.org
Subject: How to test my patches before submitting them to LKML?
Date: Fri, 7 Feb 2014 12:51:42 -0800 [thread overview]
Message-ID: <20140207205142.GA20170@worldash.org> (raw)
In-Reply-To: <36523.1391797811@turing-police.cc.vt.edu>
On Feb 07 2014, Valdis.Kletnieks at vt.edu wrote:
>
> On Fri, 07 Feb 2014 18:30:46 +0100, Matthias Beyer said:
>
> > So you would say, I should start patching non-hardware driver code,
> > FS for example, to get my feet wet with the kernel?
>
> You might want to take a step back, be a bit more meta, and ask yourself
> why, exactly, you want to do kernel hacking at all. If there isn't an
> obvious part of the kernel that interests you, maybe kernel hacking isn't
> where you should be.
Personally, I'm annoyed by coding cruft. If I thought I could upstream
clean up changes successfully, I'd make a lot of them ;-) It was
probably a good thing to warn the OP that upstreaming such changes is
going to be extremely difficult. But _making_ and _testing_ that kind
of changes is as good a way to get one's hands dirty as any, and
better than some.
And IMO, getting one's hands dirty - preferably with more than just
trivial changes or isolated add-ons - is the best way to really
learn. Yes, you need to walk before you can run. And (eventually)
getting feedback will teach you things you might not have learned any
other way. But making changes, testing them, and *not* upstreaming
most of them, can teach you a lot.
Personally, I have 2 goals:
- get paid
- get good enough at linux to successfully play in the core kernel
(successful == get changes accepted routinely, etc. etc.)
Doing the former mostly just requires finding the right upstream patch
to apply to our product's elderly kernel, and/or explaining to
developers why their design choices are creating performance issues.
But even getting good at that limited goal is enhanced by simply
mucking around, writing things that may well duplicate existing
functionality, making big design changes beyond my present skill
level, and generally getting close and personal with the source
code. I wish I had more time to do that, rather than chasing down
(e.g.) the latest thing in creative misuse of the hugetlbfs ;-)
Of course when I start upstreaming stuff, it'll probably be obvious
fixes for trivial bugs, and/or hardware enablement. I know my skill
and reputation level ;-)
And the less I get time to just mess around with code, the less likely
I'll achieve the second goal. Given that I'm not doing much on my own
time, I'd say I'm not all that dedicated to it ;-(
--
Arlie
(Arlie Stephens arlie at worldash.org)
next prev parent reply other threads:[~2014-02-07 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 15:31 How to test my patches before submitting them to LKML? Matthias Beyer
2014-02-07 16:10 ` Valdis.Kletnieks at vt.edu
2014-02-07 17:30 ` Matthias Beyer
2014-02-07 18:30 ` Valdis.Kletnieks at vt.edu
2014-02-07 19:05 ` Robert P. J. Day
2014-02-07 20:51 ` Arlie Stephens [this message]
2014-02-07 23:46 ` Valdis.Kletnieks at vt.edu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207205142.GA20170@worldash.org \
--to=arlie@worldash.org \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).