From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Could I send a patch which I'm not sure it was correct?
Date: Sat, 29 Mar 2014 09:48:06 -0700 [thread overview]
Message-ID: <20140329164806.GA29295@kroah.com> (raw)
In-Reply-To: <4d799be6.582b.1450e0c306a.Coremail.asuka.com@163.com>
On Sat, Mar 29, 2014 at 09:34:11PM +0800, wei zhang wrote:
> Hi
>
> I found a bug and send a trivial patch to fix it. The kind maintainer gave me some advice about this patch.
> I'm not familier with it and this is a challenge to me, I want to do it as my best, but I'm afraid that it is impolite
> to send a patch, which I'm not sure it?was correct!
Explain that you don't really know if this patch is correct, but you
tried to fix it the best you could, and could the maintainer and
community please review the patch.
It's fine if you don't know if it correct, that's how you learn!
good luck,
greg k-h
next prev parent reply other threads:[~2014-03-29 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-29 13:34 Could I send a patch which I'm not sure it was correct? wei zhang
2014-03-29 16:48 ` Greg KH [this message]
2014-03-30 2:03 ` wei zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140329164806.GA29295@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).