* Could I send a patch which I'm not sure it was correct?
@ 2014-03-29 13:34 wei zhang
2014-03-29 16:48 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: wei zhang @ 2014-03-29 13:34 UTC (permalink / raw)
To: kernelnewbies
Hi
I found a bug and send a trivial patch to fix it. The kind maintainer gave me some advice about this patch.
I'm not familier with it and this is a challenge to me, I want to do it as my best, but I'm afraid that it is impolite
to send a patch, which I'm not sure it?was correct!
This is my first time to send a patch to the kernel, any advice is appreciated!
Regards,
Wei Zhang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Could I send a patch which I'm not sure it was correct?
2014-03-29 13:34 Could I send a patch which I'm not sure it was correct? wei zhang
@ 2014-03-29 16:48 ` Greg KH
2014-03-30 2:03 ` wei zhang
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2014-03-29 16:48 UTC (permalink / raw)
To: kernelnewbies
On Sat, Mar 29, 2014 at 09:34:11PM +0800, wei zhang wrote:
> Hi
>
> I found a bug and send a trivial patch to fix it. The kind maintainer gave me some advice about this patch.
> I'm not familier with it and this is a challenge to me, I want to do it as my best, but I'm afraid that it is impolite
> to send a patch, which I'm not sure it?was correct!
Explain that you don't really know if this patch is correct, but you
tried to fix it the best you could, and could the maintainer and
community please review the patch.
It's fine if you don't know if it correct, that's how you learn!
good luck,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Could I send a patch which I'm not sure it was correct?
2014-03-29 16:48 ` Greg KH
@ 2014-03-30 2:03 ` wei zhang
0 siblings, 0 replies; 3+ messages in thread
From: wei zhang @ 2014-03-30 2:03 UTC (permalink / raw)
To: kernelnewbies
At?2014-03-30?00:48:06,"Greg?KH"?<greg@kroah.com>?wrote:
>On?Sat,?Mar?29,?2014?at?09:34:11PM?+0800,?wei?zhang?wrote:
>>?Hi
>>?
>>?I?found?a?bug?and?send?a?trivial?patch?to?fix?it.?The?kind?maintainer?gave?me?some?advice?about?this?patch.
>>?I'm?not?familier?with?it?and?this?is?a?challenge?to?me,?I?want?to?do?it?as?my?best,?but?I'm?afraid?that?it?is?impolite
>>?to?send?a?patch,?which?I'm?not?sure?it?was?correct!
>
>Explain?that?you?don't?really?know?if?this?patch?is?correct,?but?you
>tried?to?fix?it?the?best?you?could,?and?could?the?maintainer?and
>community?please?review?the?patch.
>
>It's?fine?if?you?don't?know?if?it?correct,?that's?how?you?learn!
Thank you very much for giving me the confidence, I will try my
best to fix it.
Regards,
Wei Zhang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-30 2:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-29 13:34 Could I send a patch which I'm not sure it was correct? wei zhang
2014-03-29 16:48 ` Greg KH
2014-03-30 2:03 ` wei zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).