From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Checkpatch.pl and code cleanup
Date: Sun, 30 Mar 2014 22:09:08 -0700 [thread overview]
Message-ID: <20140331050908.GA24763@kroah.com> (raw)
In-Reply-To: <CAAZ620M1EjKsK7HFaXxG-kmq9PSy8dnQwSTmvYSGcAQho_sK=Q@mail.gmail.com>
On Mon, Mar 31, 2014 at 10:15:14AM +0530, Abhijeet Kasurde wrote:
> Hi All,
>
> Pardon me, if this question is asked previously,
>
> Recently, I came across script in Linux Kernel called 'checkpatch.pl'
> which is checks coding style of a patch or file.
>
> Out of curiosity, I ran script on multiple modules and saw indentation
> and other errors in coding style. So question is, Can I fix them or
> these errors in coding style are "low hanging fruits" for now ?
For some parts of the kernel, checkpatch fixes are gladly accepted, like
drivers/staging/*. Other parts, it's harder to get them accepted as the
code is old and no one wants to touch it anymore (like scsi drivers.)
good luck,
greg k-h
next prev parent reply other threads:[~2014-03-31 5:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 4:45 Checkpatch.pl and code cleanup Abhijeet Kasurde
2014-03-31 5:09 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-31 4:59 harris bohr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331050908.GA24763@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).