* Checkpatch.pl and code cleanup
@ 2014-03-31 4:45 Abhijeet Kasurde
2014-03-31 5:09 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Abhijeet Kasurde @ 2014-03-31 4:45 UTC (permalink / raw)
To: kernelnewbies
Hi All,
Pardon me, if this question is asked previously,
Recently, I came across script in Linux Kernel called 'checkpatch.pl'
which is checks coding style of a patch or file.
Out of curiosity, I ran script on multiple modules and saw indentation
and other errors in coding style. So question is, Can I fix them or
these errors in coding style are "low hanging fruits" for now ?
Thanks,
Abhijeet Kasurde
^ permalink raw reply [flat|nested] 3+ messages in thread
* Checkpatch.pl and code cleanup
@ 2014-03-31 4:59 harris bohr
0 siblings, 0 replies; 3+ messages in thread
From: harris bohr @ 2014-03-31 4:59 UTC (permalink / raw)
To: kernelnewbies
better spend time on learning the kernel internals than coding style errors. if you improve the code, fix the check patch roots around that code and send in a patch
Abhijeet Kasurde <abhijeetkasurde21@gmail.com> wrote:
>Hi All,
>
>Pardon me, if this question is asked previously,
>
>Recently, I came across script in Linux Kernel called 'checkpatch.pl'
>which is checks coding style of a patch or file.
>
>Out of curiosity, I ran script on multiple modules and saw indentation
>and other errors in coding style. So question is, Can I fix them or
>these errors in coding style are "low hanging fruits" for now ?
>
>Thanks,
>Abhijeet Kasurde
>
>_______________________________________________
>Kernelnewbies mailing list
>Kernelnewbies at kernelnewbies.org
>http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
^ permalink raw reply [flat|nested] 3+ messages in thread
* Checkpatch.pl and code cleanup
2014-03-31 4:45 Checkpatch.pl and code cleanup Abhijeet Kasurde
@ 2014-03-31 5:09 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2014-03-31 5:09 UTC (permalink / raw)
To: kernelnewbies
On Mon, Mar 31, 2014 at 10:15:14AM +0530, Abhijeet Kasurde wrote:
> Hi All,
>
> Pardon me, if this question is asked previously,
>
> Recently, I came across script in Linux Kernel called 'checkpatch.pl'
> which is checks coding style of a patch or file.
>
> Out of curiosity, I ran script on multiple modules and saw indentation
> and other errors in coding style. So question is, Can I fix them or
> these errors in coding style are "low hanging fruits" for now ?
For some parts of the kernel, checkpatch fixes are gladly accepted, like
drivers/staging/*. Other parts, it's harder to get them accepted as the
code is old and no one wants to touch it anymore (like scsi drivers.)
good luck,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-31 5:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-31 4:45 Checkpatch.pl and code cleanup Abhijeet Kasurde
2014-03-31 5:09 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-03-31 4:59 harris bohr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).