kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Patch submission issue
Date: Tue, 10 Jun 2014 19:29:11 -0700	[thread overview]
Message-ID: <20140611022911.GA2698@kroah.com> (raw)
In-Reply-To: <5397B684.7060403@cdac.in>

On Wed, Jun 11, 2014 at 07:23:08AM +0530, Raghavendra wrote:
> Hello,
> 
> I am new to the kernel development community and I started off by fixing 
> small coding style errors in the drivers/staging directory. I've created 
> a patch for the same and sent it to the maintainer. The maintainer 
> replied to me something like this :
> 
> "
> Please don't do multiple things in the same patch, a single patch should
> only do 1 thing.  So break this up into multiple patches.
> "
> 
> And my patch looks something like this :
> 
>  From 7effd3d61c6ce08cd44df0a5ba3d1e9ac9ab5a98 Mon Sep 17 00:00:00 2001
> 
> From: Raghavendra <arrao@cdac.in>
> 
> Date: Tue, 10 Jun 2014 22:04:52 +0530
> 
> Subject: [PATCH] Staging: rtl8192e: dot11d: Fixed coding style issues
> 
> Replaced 'printk' with 'netdev_info' and 'netdev_err' wherever necessary.
> 
> Also fixed the coding issue cooresponding to line gap after the declarations.

You said "also", so that means you did 2 different things.  Split this
up into two different patches, one doing the first thing, and the second
the second thing.

See the documentation for how to do multiple patches in an email series.

thanks,

greg k-h

  reply	other threads:[~2014-06-11  2:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11  1:53 Patch submission issue Raghavendra
2014-06-11  2:29 ` Greg KH [this message]
2014-06-11 13:25   ` Scott Lovenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140611022911.GA2698@kroah.com \
    --to=greg@kroah.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).