kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] reformat_with_checkpatch: Add automation to checkpatch
Date: Fri, 11 Jul 2014 19:01:14 -0700	[thread overview]
Message-ID: <20140712020114.GA12301@kroah.com> (raw)
In-Reply-To: <1405129612.6751.24.camel@joe-AO725>

On Fri, Jul 11, 2014 at 06:46:52PM -0700, Joe Perches wrote:
> On Fri, 2014-07-11 at 18:39 -0700, Greg KH wrote:
> > On Fri, Jul 11, 2014 at 06:21:27PM -0700, Joe Perches wrote:
> > > A simple script to run checkpatch --fix for various types of
> > > of cleanups.
> ]
> > drivers/staging/lustre/include/linux/lnet/api.h has no obvious style problems and is ready for submission.
> > file: <drivers/staging/lustre/include/linux/lnet/api.h> description: <update c90 comment style> types:<c99_comments>
> > Useless use of greediness modifier '+' in regex; marked by <-- HERE in m/(^\+.*) {8,8}+ <-- HERE \t/@./scripts/checkpatch.pl line 2217.
> []
> > drivers/staging/lustre/include/linux/lnet/api.h has no obvious style problems and is ready for submission.
> []
> > Is that expected?
> 
> No, I haven't seen that.
> 
> Can you tell me what git tree you're working on?

My staging-next branch of staging.git on git.kernel.org

> Also, can you use the scripts/checkpatch from -next
> tag next-20140711

that will take a bit to checkout, I'll do that afterward.

> My system has:
> 
> $ perl --version 
> 
> This is perl 5, version 18, subversion 2 (v5.18.2) built for i686-linux-gnu-thread-multi-64int
> (with 41 registered patches, see perl -V for more detail)

I think this started showing up for me for perl 5.20.  Let me go
checkout linux-next and see if that fixes anything or not...

thanks,

greg k-h

  reply	other threads:[~2014-07-12  2:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12  1:21 [PATCH] reformat_with_checkpatch: Add automation to checkpatch Joe Perches
2014-07-12  1:34 ` Greg KH
2014-07-12  1:40   ` Joe Perches
2014-07-12  2:34     ` Greg KH
2014-07-12  9:30     ` Dan Carpenter
2014-07-12 17:55       ` Greg KH
2014-07-12 18:29         ` Joe Perches
2014-07-12 19:28           ` Greg KH
2014-07-13  3:06             ` Joe Perches
2014-07-12  1:39 ` Greg KH
2014-07-12  1:46   ` Joe Perches
2014-07-12  2:01     ` Greg KH [this message]
2014-07-12  2:05       ` Greg KH
2014-07-12  2:09         ` [PATCH] checkpatch: Remove unnecessary + after {8,8} Joe Perches
2014-07-12  2:23           ` Greg KH
2014-08-31 20:58           ` Sören Brinkmann
2014-09-01 16:55         ` [PATCH - resend] " Joe Perches
2014-10-30 11:12           ` Borislav Petkov
2014-10-30 11:15             ` Borislav Petkov
2014-07-12  1:43 ` [PATCH] reformat_with_checkpatch: Add automation to checkpatch Greg KH
2014-07-12  1:50   ` Joe Perches
2014-07-12  1:53 ` Greg KH
2014-07-12  1:57   ` Joe Perches
2014-07-12  2:15     ` Greg KH
2014-07-12  8:08     ` Greg KH
2014-07-12  8:18 ` Greg KH
2014-07-12 10:13   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140712020114.GA12301@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).