From: tytso@mit.edu (Theodore Ts'o)
To: kernelnewbies@lists.kernelnewbies.org
Subject: How to automate checkpatch && get_maintainers && git send-email of commits range?
Date: Fri, 18 Jul 2014 18:22:15 -0400 [thread overview]
Message-ID: <20140718222215.GF18775@thunk.org> (raw)
In-Reply-To: <CANZNk81LiTM9vY0dRV=T0BCT9k-BxU45Ojw_PyOcpdmtXHKM2Q@mail.gmail.com>
On Fri, Jul 18, 2014 at 05:38:30PM +0300, Andrey Utkin wrote:
> Is there script for automated checkpatch.pl && get_maintainers.pl &&
> git send-email for range of commits? I see none. Would it be welcome
> to submit such one to kernel tree?
Too much automation can be a really bad thing. You **really** want to
sanity check the output of checkpatch.pl and get_maintainers.pl.
Their output is not always correct, and some amount of human common
sense is required. (Granted Nick Krause hasn't shown much in the way
of common sense, but some human intervention --- assuming he is human
and not an badly written, automated troll program --- is better than
none.)
The other thing is that I strongly recommend that people use git
format-patch first, to make sure that what you will be blasting out to
thousands of peoples' mail boxes is in fact sane.
And then think very hard about which patches people need to see in
order to be able to evaluate a patch. For example, if you have patch
1 out of a series which adds a new function, and then patches 2
through 1000 modify a thousand different drivers to use that new
function, if you use an automated get_maintainers.pl script to send
each patch to just the maintainer, then the device driver maintainer
might not see patch #1 which is critical context to understanding the
patch that you want to make to his driver. And then you will have
several hundred very angry and annoyed developers wondering why you
sent them patch 345/1000, with no other context, and wondering what
the heck they are supposed to do with the email that you have just
launched into their inbox.
There's a reason why many developers cordially hate these scripts;
it's too easy to misuse them, and unfortunately, there are too many
Nick Krause like idiots out there who mindlessly use such scripts and
cause pain to maintainers. The critical step is to force such idiots
to stop and ***think*** and unfortunately, automation seems to
encourage the opposite behaviour.
Regards,
- Ted
next prev parent reply other threads:[~2014-07-18 22:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 14:38 How to automate checkpatch && get_maintainers && git send-email of commits range? Andrey Utkin
[not found] ` <20140718144621.GA12871@lip6.fr>
2014-07-18 15:24 ` Andrey Utkin
2014-07-18 20:40 ` Greg KH
2014-07-18 22:22 ` Theodore Ts'o [this message]
2014-07-18 22:47 ` Joe Perches
2014-07-18 22:50 ` Joe Perches
2014-07-19 1:31 ` Steven Rostedt
2014-07-19 3:35 ` Hillf Danton
2014-07-19 4:05 ` Nick Krause
2014-07-20 22:23 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718222215.GF18775@thunk.org \
--to=tytso@mit.edu \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).