From: dev@snitselaar.org (Jerry Snitselaar)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] staging: Check for Null return of allocated skb in fw_download_code
Date: Wed, 13 Aug 2014 11:25:47 -0700 [thread overview]
Message-ID: <20140813182547.GA25406@cantor.redhat.com> (raw)
In-Reply-To: <CAMo8BfJgVoyACTgkkVV5fYbNYN26L_SJJ06-Bs09hSBgwyuvMw@mail.gmail.com>
On Wed Aug 13 14, Max Filippov wrote:
> On Wed, Aug 13, 2014 at 10:03 PM, Nick Krause <xerofoify@gmail.com> wrote:
> > I did test my patch by doing a kernel build and I get this error,
> > drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c:66:4: error:
> > implicit declaration of function ?skb_quene_purge?
> > [-Werror=implicit-function-declaration]
> > skb_quene_purge(&priv->rtllib->skb_waitQ[tcb_desc->queue_index]);
> > I am wondering how do I fix this, I will attach my patch so I can fix
> > this out and send a proper patch :).
>
> Typo, skb_queue_purge.
>
I imagine that array index isn't going to go over very well.
Jerry
next prev parent reply other threads:[~2014-08-13 18:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 3:24 [PATCH] staging: Check for Null return of allocated skb in fw_download_code Nicholas Krause
2014-08-13 3:31 ` Nick Krause
2014-08-13 5:35 ` Valdis.Kletnieks at vt.edu
2014-08-13 5:53 ` Manish Katiyar
2014-08-13 13:56 ` Valdis.Kletnieks at vt.edu
2014-08-13 14:50 ` Max Filippov
2014-08-13 16:02 ` Valdis.Kletnieks at vt.edu
2014-08-13 16:55 ` Nick Krause
2014-08-13 18:03 ` Nick Krause
2014-08-13 18:09 ` Philipp Muhoray
2014-08-13 18:11 ` Max Filippov
2014-08-13 18:25 ` Jerry Snitselaar [this message]
2014-08-13 18:27 ` Nick Krause
2014-08-13 18:58 ` Nick Krause
2014-08-13 18:20 ` Jeff Haran
2014-08-13 19:17 ` Valdis.Kletnieks at vt.edu
2014-08-13 19:24 ` Nick Krause
2014-08-13 19:52 ` Nick Krause
2014-08-13 19:06 ` Valdis.Kletnieks at vt.edu
-- strict thread matches above, loose matches on Subject: below --
2014-08-13 3:12 Nicholas Krause
2014-08-13 3:14 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813182547.GA25406@cantor.redhat.com \
--to=dev@snitselaar.org \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).