From mboxrd@z Thu Jan  1 00:00:00 1970
From: greg@kroah.com (Greg KH)
Date: Tue, 16 Sep 2014 17:37:35 -0700
Subject: A quick guide to why stand-alone checkpatch patches suck...
In-Reply-To: <140649.1410913551@turing-police.cc.vt.edu>
References: <140649.1410913551@turing-police.cc.vt.edu>
Message-ID: <20140917003735.GA17666@kroah.com>
To: kernelnewbies@lists.kernelnewbies.org
List-Id: kernelnewbies.lists.kernelnewbies.org

On Tue, Sep 16, 2014 at 08:25:51PM -0400, Valdis Kletnieks wrote:
> In general, stand-alone patches to "fix" checkpatch whining are a Bad Idea(TM).

<snip>

And here's why checkpatch patches are a "Good Idea(TM)":
  - it teaches you how to set up your email client properly
  - it teaches you how to describe a patch properly
  - it teaches you how to submit a patch properly
  - it gives you a good feedback loop
  - it is an "easy" place to start.

But, and this is a huge BUT, which you ignored, you should ONLY submit a
checkpatch cleanup for a subsystem that has a maintainer that welcomes
them.

Like drivers/staging/*.  Checkpatch cleanups are welcome, and encouraged
there.  If you want to do a checkpatch cleanup, do it there, you will
not be yelled at.

thanks,

greg k-h