From mboxrd@z Thu Jan  1 00:00:00 1970
From: greg@kroah.com (Greg KH)
Date: Tue, 16 Sep 2014 21:56:28 -0700
Subject: A quick guide to why stand-alone checkpatch patches suck...
In-Reply-To: <153669.1410925338@turing-police.cc.vt.edu>
References: <140649.1410913551@turing-police.cc.vt.edu>
	<CAO+WgCaEaeRF-jtEgOsN1ZHQ9UzEq99msQPnZMmaqN==adafNg@mail.gmail.com>
	<153669.1410925338@turing-police.cc.vt.edu>
Message-ID: <20140917045628.GB19159@kroah.com>
To: kernelnewbies@lists.kernelnewbies.org
List-Id: kernelnewbies.lists.kernelnewbies.org

On Tue, Sep 16, 2014 at 11:42:18PM -0400, Valdis.Kletnieks at vt.edu wrote:
> (And this sort of analysis is exactly *why* people need to apply their brains
> when looking at checkpatch output....)

No one has ever said that they shouldn't.

Remember, I know _lots_ of kernel developers who started with just
"checkpatch cleanups on staging drivers" and they moved on to much
"higher" roles in the kernel developer ecosystem (jobs, maintainers of
subsystems, keynote talks at conferences, etc.)

Don't "po po" it as something that shouldn't be a valid place to start,
it is, and is why I do the work to review all of the many thousands of
staging patches every release cycle.

No one is forcing you to write those patches, or read / review them, so
don't discourage others to provide them either please.  I most certainly
do not.

thanks,

greg k-h