From: sudipm.mukherjee@gmail.com (Sudip Mukherjee)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c
Date: Wed, 22 Oct 2014 10:20:36 +0530 [thread overview]
Message-ID: <20141022045036.GA3493@sudip-PC> (raw)
In-Reply-To: <CAL3LdT7ZA5Fq3LxbEKyyLGt8BYWDOVWGg=Sae-cdMqDP_yCRUA@mail.gmail.com>
On Tue, Oct 21, 2014 at 08:31:25PM -0700, Jeff Kirsher wrote:
> On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
> > Fix checkpatch error message with opening bracket of if statement,
> > not being on the same line as a if statement in rtw_ap.c
> >
> > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> > ---
> > drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> I will say, it does appear you finally got a patch right. Only issue
i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
> I have is that you corrected only one of the many instances of the
> same problem in this file.
> If you are going to correct one instance, might as well fix them all.
don't you think if he tries to fix them all at one go, he will again mess up everything ?
thanks
sudip
>
> >
> > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> > index 6b4092f..927b2a6 100644
> > --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> > +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> > @@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info
> > }
> > }
> >
> > - if (rtw_ht_operation_update(padapter) > 0)
> > - {
> > + if (rtw_ht_operation_update(padapter) > 0) {
> > update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, false);
> > update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
> > }
> > --
> > 1.9.1
> >
> >
> > _______________________________________________
> > Kernelnewbies mailing list
> > Kernelnewbies at kernelnewbies.org
> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
>
>
> --
> Cheers,
> Jeff
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
next prev parent reply other threads:[~2014-10-22 4:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 17:34 [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c Nicholas Krause
2014-10-22 3:31 ` Jeff Kirsher
2014-10-22 4:50 ` Sudip Mukherjee [this message]
2014-10-22 5:05 ` nick
2014-10-22 5:25 ` Sudip Mukherjee
2014-10-22 5:28 ` Jeff Kirsher
2014-10-22 5:20 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022045036.GA3493@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).