How to send the [PATCH 0/x] kind of emails?

How to send the [PATCH 0/x] kind of emails?

[Mandeep Sandhu]

How does one send this kind of summary email? Is it generated manually
or through some git format-patch/send-email foo magic?

I have 4 patches that I have to submit. I'd like to send a summary
email (0/4) explaining the changes.

Thanks,
-mandeep

How to send the [PATCH 0/x] kind of emails?

[Greg KH]

On Fri, Dec 12, 2014 at 02:05:50PM -0800, Mandeep Sandhu wrote:
> How does one send this kind of summary email? Is it generated manually
> or through some git format-patch/send-email foo magic?
> 
> I have 4 patches that I have to submit. I'd like to send a summary
> email (0/4) explaining the changes.

git send-email --compose

How to send the [PATCH 0/x] kind of emails?

[Mandeep Sandhu]

Ok got it. The answer was right there at the end of the git send-email
man page! I should've 'scrolled' harder! :P

$ git format-patch --cover-letter -M origin/master -o outgoing/
$ edit outgoing/0000-*
$ git send-email outgoing/*

Regards,
-mandeep


On Fri, Dec 12, 2014 at 2:05 PM, Mandeep Sandhu
<mandeepsandhu.chd@gmail.com> wrote:
> How does one send this kind of summary email? Is it generated manually
> or through some git format-patch/send-email foo magic?
>
> I have 4 patches that I have to submit. I'd like to send a summary
> email (0/4) explaining the changes.
>
> Thanks,
> -mandeep

How to send the [PATCH 0/x] kind of emails?

[Mandeep Sandhu]

Thanks Greg!

One more thing. Should the 'Tested-by:' tag be added in every commit
manually, or only one of them is enough (the last patch really
implements the functionality and the rest are 'preparatory' commits)?

-mandeep


On Fri, Dec 12, 2014 at 2:27 PM, Greg KH <greg@kroah.com> wrote:
> On Fri, Dec 12, 2014 at 02:05:50PM -0800, Mandeep Sandhu wrote:
>> How does one send this kind of summary email? Is it generated manually
>> or through some git format-patch/send-email foo magic?
>>
>> I have 4 patches that I have to submit. I'd like to send a summary
>> email (0/4) explaining the changes.
>
> git send-email --compose
>

How to send the [PATCH 0/x] kind of emails?

[Greg KH]

On Fri, Dec 12, 2014 at 02:29:22PM -0800, Mandeep Sandhu wrote:
> Thanks Greg!
> 
> One more thing. Should the 'Tested-by:' tag be added in every commit
> manually, or only one of them is enough (the last patch really
> implements the functionality and the rest are 'preparatory' commits)?

"Tested-by" is only for people who test the patch, not for the people
who wrote the patch.  It is implied that the person who wrote the patch
also tested it, otherwise they shouldn't be sending the patch in the
firat place, right?

Hope this helps,

greg k-h

How to send the [PATCH 0/x] kind of emails?

[Mandeep Sandhu]

On Fri, Dec 12, 2014 at 8:02 PM, Greg KH <greg@kroah.com> wrote:
> On Fri, Dec 12, 2014 at 02:29:22PM -0800, Mandeep Sandhu wrote:
>> Thanks Greg!
>>
>> One more thing. Should the 'Tested-by:' tag be added in every commit
>> manually, or only one of them is enough (the last patch really
>> implements the functionality and the rest are 'preparatory' commits)?
>
> "Tested-by" is only for people who test the patch, not for the people
> who wrote the patch.  It is implied that the person who wrote the patch
> also tested it, otherwise they shouldn't be sending the patch in the
> firat place, right?

Right, although in my case, I'm not the original author of this patch.
This is the uio hotplug patch that I talked to you about on this ML a
few days back (which somehow missed inclusion almost 4 years back).

I'm simply following your suggestion, that is re-submitting the patch
(after making some minor modifications to it for making it work with
newer kernels). The original patch author is "Eric W. Biederman". I
have tested this patch for my use-case (with a PCIE hotplug device)
and I have also written a small "fake hotplug" driver which validates
this patch (https://github.com/mandeepsandhu/uio-hotplug-test).

Let me know if this is not the appropriate way to submit the patch (if
only the original author should submit it instead).

Thanks for your time.

Regards,
-mandeep

>
> Hope this helps,
>
> greg k-h

How to send the [PATCH 0/x] kind of emails?

[Greg KH]

On Fri, Dec 12, 2014 at 10:36:00PM -0800, Mandeep Sandhu wrote:
> On Fri, Dec 12, 2014 at 8:02 PM, Greg KH <greg@kroah.com> wrote:
> > On Fri, Dec 12, 2014 at 02:29:22PM -0800, Mandeep Sandhu wrote:
> >> Thanks Greg!
> >>
> >> One more thing. Should the 'Tested-by:' tag be added in every commit
> >> manually, or only one of them is enough (the last patch really
> >> implements the functionality and the rest are 'preparatory' commits)?
> >
> > "Tested-by" is only for people who test the patch, not for the people
> > who wrote the patch.  It is implied that the person who wrote the patch
> > also tested it, otherwise they shouldn't be sending the patch in the
> > firat place, right?
> 
> Right, although in my case, I'm not the original author of this patch.
> This is the uio hotplug patch that I talked to you about on this ML a
> few days back (which somehow missed inclusion almost 4 years back).

Ok, then yes, add a tested-by on every patch that you tested.

> I'm simply following your suggestion, that is re-submitting the patch
> (after making some minor modifications to it for making it work with
> newer kernels). The original patch author is "Eric W. Biederman". I
> have tested this patch for my use-case (with a PCIE hotplug device)
> and I have also written a small "fake hotplug" driver which validates
> this patch (https://github.com/mandeepsandhu/uio-hotplug-test).
> 
> Let me know if this is not the appropriate way to submit the patch (if
> only the original author should submit it instead).

Have you asked the original author about this?  There has to be some
reason the patch was not accepted, right?  Try asking them what happened
to see if they remember.  I can't remember what happened with a specific
patch yesterday, I deal with too many patches to be able to remember
anything, but usually the author has a bit better recollection.

It's ok to submit other people's patches, but it's a nice idea to ask
them about it before doing so.

good luck,

greg k-h

How to send the [PATCH 0/x] kind of emails?

[Mandeep Sandhu]

>
> Have you asked the original author about this?  There has to be some
> reason the patch was not accepted, right?  Try asking them what happened

No, because the email address recorded in the patch is no longer valid.

> to see if they remember.  I can't remember what happened with a specific
> patch yesterday, I deal with too many patches to be able to remember
> anything, but usually the author has a bit better recollection.

I could not find any NACK or any sort of comment on the original patch
submission. The only email I saw related to these patches was that it
didn't apply cleanly on the previous patch-set (also submitted by the
same author, and merged in by you). You had mentioned thta since the
patch didn't apply cleanly, you had deleted the patch-set and had
asked for it to be re-submitted (which the original author did).

>
> It's ok to submit other people's patches, but it's a nice idea to ask
> them about it before doing so.

I was hoping that Eric Biederman might still be there on LKML and that
he might jump in once I post the patches! :)

I'll add a 'Tested-by' to each of the commits and submit the patch-set.

Thanks,
-mandeep


>
> good luck,
>
> greg k-h

How to send the [PATCH 0/x] kind of emails?

[Greg KH]

On Sun, Dec 14, 2014 at 09:18:54AM -0800, Mandeep Sandhu wrote:
> >
> > Have you asked the original author about this?  There has to be some
> > reason the patch was not accepted, right?  Try asking them what happened
> 
> No, because the email address recorded in the patch is no longer valid.

If that's the case, then I can't accept an invalid "From:" line on a
patch, sorry.  I need an address of someone that will be responsible for
it.

So in that case, put your address as a "From:" and in the body say,
"Originally written by .... but forward ported by me" or something to
that affect.

thanks,

greg k-h

How to send the [PATCH 0/x] kind of emails?

[Mandeep Sandhu]

On Sun, Dec 14, 2014 at 10:25 AM, Greg KH <greg@kroah.com> wrote:
> On Sun, Dec 14, 2014 at 09:18:54AM -0800, Mandeep Sandhu wrote:
>> >
>> > Have you asked the original author about this?  There has to be some
>> > reason the patch was not accepted, right?  Try asking them what happened
>>
>> No, because the email address recorded in the patch is no longer valid.
>
> If that's the case, then I can't accept an invalid "From:" line on a
> patch, sorry.  I need an address of someone that will be responsible for
> it.

Got it. Although I think Eric might be active on LKML, albeit with a
different address. I'm hoping he'll pitch in once I submit the patch
with your suggestions.

Thanks again,
-mandeep


>
> So in that case, put your address as a "From:" and in the body say,
> "Originally written by .... but forward ported by me" or something to
> that affect.
>
> thanks,
>
> greg k-h