From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: [PATCH v2 0/2] ATM: HE: Cleanup coding style
Date: Mon, 15 Dec 2014 16:40:19 -0800 [thread overview]
Message-ID: <20141216004019.GC27104@kroah.com> (raw)
In-Reply-To: <1418689601-25679-1-git-send-email-jjin082693@gmail.com>
On Mon, Dec 15, 2014 at 06:26:39PM -0600, Jonathan Jin wrote:
> At Greg KH's advice, I've revised my previous formatting patch by splicing it
> into two separate patches in the same sequence. If I could get additional
> feedback, I'd very much appreciate it.
>
> This patch sequence cleans up the following coding style issues that are
> detected by checkpatch:
> ERROR: trailing whitespace
> ERROR: open brace '{' following struct go on the same line
>
> Jonathan Jin (2):
> ATM: HE: Cleanup coding style (whitespace)
> ATM: HE: Cleanup coding style (struct braces)
>
> drivers/atm/he.h | 25 +++++++++++--------------
> 1 file changed, 11 insertions(+), 14 deletions(-)
Looks good, just the one nit about the leading spaces in the changelog
entry.
But note, some maintainers don't care about patches like this, so if
they are ignored, be prepared. If they don't get picked up in a month
or so, try a subsystem that wants these types of patches, like the
staging tree.
thanks,
greg k-h
next prev parent reply other threads:[~2014-12-16 0:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 0:26 [PATCH v2 0/2] ATM: HE: Cleanup coding style Jonathan Jin
2014-12-16 0:26 ` [PATCH v2 1/2] ATM: HE: Cleanup coding style (whitespace) Jonathan Jin
2014-12-16 0:26 ` [PATCH v2 2/2] ATM: HE: Cleanup coding style (struct braces) Jonathan Jin
2014-12-16 0:39 ` Greg KH
2014-12-16 0:40 ` Greg KH [this message]
2014-12-16 1:08 ` [PATCH v2 0/2] ATM: HE: Cleanup coding style Jonathan Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216004019.GC27104@kroah.com \
--to=greg@kroah.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).