kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Solving checkpatch error with lex
Date: Wed, 17 Dec 2014 11:36:20 -0800	[thread overview]
Message-ID: <20141217193620.GA29107@kroah.com> (raw)
In-Reply-To: <CAOLa=ZS0gsf9a4RSvnsa+B+-Fv1x_jovVVOpF4rh-Qpp37cXsA@mail.gmail.com>

On Wed, Dec 17, 2014 at 07:10:24PM +0000, karthik nayak wrote:
> 
> On Thu, Dec 18, 2014, 12:37 AM?Paul Bolle <pebolle@tiscali.nl> wrote:
> 
>     On Thu, 2014-12-18 at 00:04 +0530, karthik nayak wrote:
>     > was trying to fix the checkpatch error of not using c99 comments in the
>     > file
>     > drivers/staging/rtl8192u/r8192U_dm.c
>     > so I wrote a lex program to do so since there were way too many to do it
>     > manually.
>     > Could anyone have a look at my lex code and tell me if I need to change
>     it.
>     > I have attached the lex code.
>     > As per my testing it works perfectly, would love a second opinion.
> 
>     I see no reason to review someone's lex code. I guess very few people
>     are actually willing to do that.
> 
>     Why don't you just send in the diff? Or even better, the patch you
>     intend to submit. Almost everybody here can read diffs or patches.
> 
>     Hope this helps,
> 
>     Paul Bolle
> 
> 
> 
> 
> Hello Paul,
> The only reason I didn't do that is cause the file is too large to manually
> have a look at, even the diff tends to be very huge.

Then the diff will not be accepted upstream either if it is too big to
review.

  reply	other threads:[~2014-12-17 19:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17 18:34 Solving checkpatch error with lex karthik nayak
2014-12-17 18:52 ` Valdis.Kletnieks at vt.edu
2014-12-17 19:07 ` Paul Bolle
2014-12-17 19:10   ` karthik nayak
2014-12-17 19:36     ` Greg KH [this message]
2014-12-17 21:24     ` Valdis.Kletnieks at vt.edu
2014-12-18  0:47       ` Greg KH
2014-12-18  6:07         ` karthik nayak
2014-12-17 19:11   ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141217193620.GA29107@kroah.com \
    --to=greg@kroah.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).