kernelnewbies.kernelnewbies.org archive mirror
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: kernelnewbies@lists.kernelnewbies.org
Subject: ternary vs double exclamation
Date: Sun, 4 Jan 2015 16:50:58 -0800	[thread overview]
Message-ID: <20150105005058.GA15400@kroah.com> (raw)
In-Reply-To: <20150104234321.GA9214@vega.jjdev.com>

On Sun, Jan 04, 2015 at 06:43:22PM -0500, John de la Garza wrote:
> On Sat, Jan 03, 2015 at 11:20:29PM -0500, Valdis.Kletnieks at vt.edu wrote:
> > On Sat, 03 Jan 2015 18:54:00 -0500, John de la Garza said:
> > 
> > > It should not be assumed that true will always be 1 as defined in
> > > include/linux/stddef.h, right?
> > 
> > No, I mean use an actual 'bool' type rather than 'int'.  Consider this from
> > kernel/softirq.c:
> 
> yes, bool has two possible values true and false
> 
> from include/linux/stddef.h:
> enum {
> 	        false   = 0,
> 		true	= 1
> };
> 
> 
> I assume it is a bad idea to depend on true being 1, right?  I mean, I
> should assume that true could be changed to any non 0 value in the future,
> right?

Why would that matter?  Just always test for "true" and "false" and you
will be fine.

greg k-h

  reply	other threads:[~2015-01-05  0:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-30  0:25 ternary vs double exclamation Vinícius Tinti
2014-12-30  0:34 ` Max Filippov
2014-12-30  0:40   ` Vinícius Tinti
2014-12-30  1:00 ` Valdis.Kletnieks at vt.edu
2014-12-30  1:04   ` Vinícius Tinti
2015-01-03 23:54   ` John de la Garza
2015-01-04  4:20     ` Valdis.Kletnieks at vt.edu
2015-01-04 23:43       ` John de la Garza
2015-01-05  0:50         ` Greg KH [this message]
2015-01-08  4:46           ` John de la Garza
2015-01-08  6:37             ` Greg KH
2015-01-05  1:17         ` Valdis.Kletnieks at vt.edu
2015-01-08  4:58           ` John de la Garza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150105005058.GA15400@kroah.com \
    --to=greg@kroah.com \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).